Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite parser for Android Airtag (attd_db) file #4939

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

hanamahes78
Copy link

@hanamahes78 hanamahes78 commented Dec 9, 2024

One line description of pull request

Add SQLite parser for Android Airtag (attd_db) file

Description:

I add and modify several files:

  • Add import android_airtag to plaso/parsers/sqlite_plugins/init.py
  • Add a new parser plugin android_airtag.py to plaso/parsers/sqlite_plugins/
  • Add attd_db file to test_data/
  • Add unit test android_airtag.py to tests/parsers/sqlite_plugins/
  • Modify android.yaml to support Android Airtag parser plugin (plaso/data/formatters/android.yaml)
  • Modify timeliner.yaml to support Android Airtag parser plugin (plaso/data/timeliner.yaml)

Related issue (if applicable): fixes #

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned
  • Test data has a Plaso compatible license

@joachimmetz joachimmetz self-assigned this Mar 2, 2025
@joachimmetz joachimmetz added the pending reporter input Issue is pending input from the reporter label Mar 2, 2025
@joachimmetz
Copy link
Member

@hanamahes78 what is the origin of the test data file?

@joachimmetz
Copy link
Member

Rebased PR

@joachimmetz
Copy link
Member

@hanamahes78 @nadiah2323 can one of you PTAL at the linter warnings.

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.10%. Comparing base (11259d3) to head (afe9fe3).

Files with missing lines Patch % Lines
plaso/parsers/sqlite_plugins/android_airtag.py 89.47% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4939   +/-   ##
=======================================
  Coverage   85.09%   85.10%           
=======================================
  Files         432      433    +1     
  Lines       38792    38830   +38     
=======================================
+ Hits        33009    33045   +36     
- Misses       5783     5785    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending reporter input Issue is pending input from the reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants