Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite parser for iOS Notes file #4944

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CandraTP
Copy link

@CandraTP CandraTP commented Dec 16, 2024

One line description of pull request

Add SQLite parser for iOS Notes file

Description:

We added and modified the following files :

  • Added a new parser plugin "ios_notes.py" to plaso/parsers/sqlite_plugins/
  • Added "NoteStore.sqlite" file to test_data/
  • Added unit test "ios_notes.py" to tests/parsers/sqlite_plugins/
  • Modified formatter "ios.yaml" (plaso/data/formatters/ios.yaml)
  • Modified "timeliner.yaml" (plaso/data/timeliner.yamll)

Related issue (if applicable): fixes #

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned
  • Test data has a Plaso compatible license

@joachimmetz joachimmetz self-assigned this Mar 2, 2025
@joachimmetz
Copy link
Member

I assume log2timeline-20241205T004447.log.gz was added by mistake?

@joachimmetz
Copy link
Member

@CandraTP what is the origin of the test data file?

@@ -1,6 +1,19 @@
# Plaso iOS related event formatters.
---
type: 'conditional'
data_type: 'ios:accounts:account'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not appear to be used, removing

@@ -487,6 +487,12 @@ attribute_mappings:
description: 'Creation Time'
place_holder_event: false
---
data_type: 'ios:accounts:account'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not appear to be used, removing

@@ -12,7 +12,7 @@ set -e;

cd config/docker;

docker build --no-cache --force-rm -t log2timeline/plaso . 2>&1 | tee ${LOGFILE};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

@joachimmetz joachimmetz added the pending reporter input Issue is pending input from the reporter label Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (11259d3) to head (dc7bc2f).

Files with missing lines Patch % Lines
plaso/parsers/sqlite_plugins/ios_notes.py 50.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4944      +/-   ##
==========================================
- Coverage   85.09%   85.06%   -0.03%     
==========================================
  Files         432      433       +1     
  Lines       38792    38824      +32     
==========================================
+ Hits        33009    33025      +16     
- Misses       5783     5799      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending reporter input Issue is pending input from the reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants