Open
Conversation
markspanbroek
force-pushed
the
vault-integration
branch
from
b9689f1 to
0f0f830
Compare
markspanbroek
force-pushed
the
vault-integration
branch
4 times, most recently
from
32d0dbd to
095e90f
Compare
markspanbroek
force-pushed
the
vault-integration
branch
2 times, most recently
from
53679b4 to
cfd30bf
Compare
markspanbroek
force-pushed
the
vault
branch
2 times, most recently
from
6a7d559 to
957f6ec
Compare
markspanbroek
force-pushed
the
vault-integration
branch
from
cfd30bf to
8a11e87
Compare
markspanbroek
force-pushed
the
vault-integration
branch
from
15d50c7 to
55fb29f
Compare
markspanbroek
force-pushed
the
vault-integration
branch
from
55fb29f to
0bdefa7
Compare
AuHau
requested changes
May 21, 2025
Contributor
There was a problem hiding this comment.
Great work, big effort! 👏
Generally LGTM, but there are a few critical points that need clarification or addressing, so I will go for the "Request changes" here.
I have gone over the contract changes, still need to see the testing of this, but that will be in round two 😅
AuHau
reviewed
May 22, 2025
AuHau
approved these changes
Jun 9, 2025
Contributor
AuHau
left a comment
AuHau
left a comment
There was a problem hiding this comment.
Nice! Generally LGTM! Just few comment here and there, but nothing blocking ;-)
Thanks again for such a big chunk of work 👏
| await waitUntilStarted(marketplace, request, proof, token) | ||
| await waitUntilFinished(marketplace, requestId(request)) | ||
| await marketplace.freeSlot(slotId(slot)) | ||
| expect(await marketplace.currentCollateral(slotId(slot))).to.equal(0) |
Contributor
There was a problem hiding this comment.
Maybe add balances checks that verify what happens to the collateral? Eq. burned vs. transfered back? Also for the tests bellow?
Contributor
Author
There was a problem hiding this comment.
Maybe I'm missing the point, but the balances are checked in the tests right above these tests ("pays out finished request base on time hosted", "pays the host when contract was cancelled" and "pays the host when contract fails and then finishes")
Vault stores balances as uint128
replaced by formal verification with certora
- removes RequestCancelled event, which was not great anyway because it is not emitted at the moment that the request is cancelled
- move all collateral calculatons to separate library
so that they can no longer be transfered within the vault
This state is no longer necessary, vault ensures that payouts happen only once. Hosts could bypass this state anyway by withdrawing from the vault directly.
- changes to marketplace constructor - we no longer have _marketplaceTotals - timestamps have their own type now - freeSlot no longer takes payout addresses - slot state 'Paid' no longer exists - freeSlot can be invoked more than once now - a failed request no longer ends immediately
No need to test the token itself
It is no longer a discount on the collateral, to simplify reasoning about collateral in the sales module of the codex node
So that a storage provider can know how much collateral is returned when it calls freeSlot()
Because a client might still need to call withdraw()
reason: freeSlot() will call forciblyFreeSlot when contract is not finished, so we can use that instead
reason: hosts are paid for the time that they hosted the slot up until the time that the request failed Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
reason: the function only depends on the request, and it is similar to the pricePerSlotPerSecond function Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
markspanbroek
force-pushed
the
vault-integration
branch
from
1ca2091 to
4410941
Compare
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
Co-Authored-By: Adam Uhlíř <adam@uhlir.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the vault for all token transfers in the marketplace. The marketplace now no longer keeps any funds itself.
This has impact on the following as well:
Timestamp,DurationandTokensPerSecondon the API