Open
Conversation
2-towns
force-pushed
the
feat/hardhat-ignition
branch
2 times, most recently
from
ee201da to
c22b6e0
Compare
AuHau
force-pushed
the
feat/upgradable-contract
branch
from
343cc17 to
10a6dca
Compare
AuHau
force-pushed
the
feat/upgradable-contract
branch
from
721f50e to
15a4331
Compare
AuHau
force-pushed
the
feat/upgradable-contract
branch
2 times, most recently
from
fcbb38e to
f9381dc
Compare
AuHau
force-pushed
the
feat/upgradable-contract
branch
from
f9381dc to
03b5227
Compare
AuHau
commented
Jun 27, 2025
Contributor
Author
There was a problem hiding this comment.
Damn, the rename destroyed the diff :-(
| @@ -1,39 +0,0 @@ | |||
| // SPDX-License-Identifier: MIT | |||
Contributor
Author
There was a problem hiding this comment.
I removed it as did not want to bother with converting it to the Initializable as it will be removed in the Vault Integration PR anyhow.
Contributor
Author
|
Safe Multisig upgrade test can be seen here: #257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225
Adds upgradable capabilities to the
Marketplacecontract using the TransparentProxy implementation.As part of the PR, I have updated the README file a bit and also added a description of how upgrades should work.
I also added tests to verify that the upgrades really work, but unfortunately, thanks to the Ignition bug, which does not support tracking of deployments in the Hardhat network, it is not really possible to natively incorporate it in the test suite yet. See here: NomicFoundation/hardhat#6927
One remaining task is to investigate how the upgrade process will work with multisig.