Removes secure_integration tag from CI script since it is internally handled.#198
Merged
mashhurs merged 2 commits intologstash-plugins:mainfrom Jul 7, 2025
Conversation
Contributor
Author
|
Failed CI step is due to expected artifact not found: |
donoghuc
reviewed
Jul 7, 2025
Remove `secure_integration ` with unit tests as well. Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Contributor
Author
|
Except the 8.future (as expected), all CI steps are 🟢 and actually run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems historically
elasticsearch_spec.rbintegration test never run withSECURE_INTEGRATIONoption.Example runs:
As
elasticsearch_spec.rbinternally applies options based onSECURE_INTEGRATIONenv var, it is not required to add an extra tag when running rspec.After this PR, we can see 6 examples are running...
