-
Notifications
You must be signed in to change notification settings - Fork 84
Esql support #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mashhurs
wants to merge
11
commits into
logstash-plugins:main
Choose a base branch
from
mashhurs:esql-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Esql support #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 4, 2025
Open
…esql option, validations to make sure both LS and ES support the ESQL execution.
… adds by default - might be users are looking for by default.
mashhurs
commented
Apr 11, 2025
|Component |Minimum version | ||
|{es} |8.11.0 or newer | ||
|{ls} |8.17.4 or newer | ||
|This plugin |4.23.0+ (4.x series) or 5.2.0+ (5.x series) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review note: before releasing this change, I will backport and release 4.23.0 first
# retriable already printed error details | ||
return if response == false | ||
|
||
if response&.headers&.dig("warning") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review note: interestingly warnings in response headers.
…/info and add docinfo* fields in ineffective fields list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ES|QL support:
response_type
acceptsesql
option distinguish from other query types. For the long term this will be deprecated and replaced byquery_type
if team agrees.METADATA
which adds_id
,_version
to the response entriessize
,search_api
,target
if users configureFYI: failed docs CI isn't related to this change.
Author's check
^...[]
special symbols on ES index, query fails but in KB Dev Tools it succeedsLogs