Skip to content

Add symlink traversal #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add symlink traversal #89

wants to merge 1 commit into from

Conversation

jrcichra
Copy link

@jrcichra jrcichra commented Sep 2, 2020

This PR allows pre-existing, strategically placed symlinks, to no longer fail on mkdir_p calls.

I've replaced mkdir_p with a loop per directory that only creates the directory if the directory doesn't exist and is not a symlink.

This solves: #87

CLA is signed (Corporation + Individual under corporation [NetApp] applies here).

@jrcichra
Copy link
Author

@roaksoax Could someone please review this? Thanks.

@jrcichra
Copy link
Author

@jsvd @roaksoax Could this please be reviewed? We'd really like to have this feature upstream. Thanks.

@jonathonpuff
Copy link

@jsvd @roaksoax looking for your help here.

@jonathonpuff
Copy link

@jsvd @roaksoax checking back in to see if we get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrcichra @jonathonpuff @roaksoax