chore: revert back to use unified Node and pnpm setup action#151
chore: revert back to use unified Node and pnpm setup action#151charIeszhao wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the GitHub Actions workflow configuration to use a unified setup action (silverhand-io/actions-node-pnpm-run-steps@v5) instead of separate pnpm and Node.js setup actions. The change simplifies the workflow configuration by consolidating the setup process.
Changes:
- Replaced separate
pnpm/action-setupandactions/setup-nodeactions with a single unifiedsilverhand-io/actions-node-pnpm-run-steps@v5action - Removed explicit
pnpm icommand from the build step (assumed to be handled by the unified action) - Changed Node version specification from exact version to caret range
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/main.yml | Updated to use unified Node/pnpm setup action and removed explicit dependency installation |
| .github/workflows/deploy.yml | Updated to use unified Node/pnpm setup action and removed explicit dependency installation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node-version: 22.14.0 | ||
| registry-url: https://registry.npmjs.org/ | ||
| cache: 'pnpm' | ||
| node-version: ^22.14.0 |
There was a problem hiding this comment.
The node version specification has changed from an exact version (22.14.0) to a caret range (^22.14.0). This allows any version 22.x.x >= 22.14.0, which could lead to inconsistent builds across different workflow runs as new Node versions are released. Consider using an exact version for reproducible builds.
| node-version: ^22.14.0 | |
| node-version: 22.14.0 |
| node-version: 22.14.0 | ||
| registry-url: https://registry.npmjs.org/ | ||
| cache: 'pnpm' | ||
| node-version: ^22.14.0 |
There was a problem hiding this comment.
The node version specification has changed from an exact version (22.14.0) to a caret range (^22.14.0). This allows any version 22.x.x >= 22.14.0, which could lead to inconsistent builds across different workflow runs as new Node versions are released. Consider using an exact version for reproducible builds.
| node-version: ^22.14.0 | |
| node-version: 22.14.0 |
Deploying auth-wiki with
|
| Latest commit: |
8d4c6ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://01fcba74.auth-wiki.pages.dev |
| Branch Preview URL: | https://charles-revert-back-to-actio.auth-wiki.pages.dev |
Summary
Revert back to use
silverhand-io/actions-node-pnpm-run-steps@v5and specify Node and pnpm versions