Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace deploy #149

Open
wants to merge 88 commits into
base: main
Choose a base branch
from

Conversation

colin-roy-ehri
Copy link
Contributor

Explore Assistant for Marketplace

Purpose

  1. Enabling marketplace deployment of EA will make it more accessible
  2. Improved security features

Significant Changes:

  1. Instead of using sql runner queries, required data is modeled in LookML. This prevents the need for escalated privileges for users (ie use_sql_runner permission).
  2. Instead of compiling environment variables into the application, these are entered in a UI and stored as user attributes. This makes the compiled .js portable.
  3. Instead of calling a cloud function endpoint through the browser, this call is proxied through Looker. This enables a closed network design
  4. Backend install flow available in Cloud Console. This makes any local ide or terminal setup unnecessary.
  5. Cloud console flow for backend setup includes step by step instructions as well as Terraform script. This makes installation in an existing Google Project possible.

Deployment Notes:

There are two related repositories, the source code repo and the LookML repo.
The LookML repo is: https://github.com/bytecodeio/explore-assistant-lookml
This Looker project repo has 3 override constants.
It is public, and it can be copied over as-is, with just 1 change (the Cloud Console link)
The source code repo is a fork of the looker-explore-assistant google repo: https://github.com/bytecodeio/looker-explore-assistant/tree/marketplace_deploy
Install includes a cloud console deployer link for the backend service. That deployer is configured to point to the ‘bytecodeio’ github organization and the marketplace_deploy branch. The code pointing to this should be changed in every readme location for it to function properly in the marketplace. It should point to the looker-open-source repo and main branch instead.
The Terraform script does not include the final security/networking steps to restrict the cloud function endpoint to Looker IPs. There are ‘manual’ instructions for that.

LukaFontanilla and others added 30 commits September 11, 2024 11:44
* fix  - pass in the parameters to the big query generate model

* make it smater

* merge

* prevent duplicate triggering of generation

* move logic into helper utils

* fix state

* fix the callbacks

* use params instead of a string

* add back sorting

* fix link generation

* remove some consoles

* check the filters twice, make sure that we're returning a simpler data structure

* fix race condition for page load

* separate call for filter and visualization generation

* fix typescript errors

* add jest tests

* update for edge cases when custom urls, and custom dates are in examples need to be handled.

* Fix package json

* more fixes post merge

* fix the store

* fix sidepanel

* fix the link to explore

* improve speed by parallelizing calls to gemini

* fix summarization

* scroll into view

* add filter helper and tests

* add tests

* run on every commit

* only use node 16 and 18

* use a filter validator

* remove un-used console logs

* post-merge fixes

* fix tests

* improve scrolling

---------

Co-authored-by: Jawad Laraqui <[email protected]>
Co-authored-by: Flavio Di Berardino <[email protected]>
Added case statement to handle both cleaned an uncleaned urls
* Added generate examples script and trusted dashboard table
adding more context to filter doc on dates
Adding context file on timeframes and intervals
adding import and reference for context
reverted/removed inline date and number filter documentation in useSendVertexMessage
@colin-roy-ehri colin-roy-ehri requested a review from a team as a code owner February 6, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants