-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace deploy #149
Open
colin-roy-ehri
wants to merge
88
commits into
looker-open-source:main
Choose a base branch
from
bytecodeio:marketplace_deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Marketplace deploy #149
colin-roy-ehri
wants to merge
88
commits into
looker-open-source:main
from
bytecodeio:marketplace_deploy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix - pass in the parameters to the big query generate model * make it smater * merge * prevent duplicate triggering of generation * move logic into helper utils * fix state * fix the callbacks * use params instead of a string * add back sorting * fix link generation * remove some consoles * check the filters twice, make sure that we're returning a simpler data structure * fix race condition for page load * separate call for filter and visualization generation * fix typescript errors * add jest tests * update for edge cases when custom urls, and custom dates are in examples need to be handled. * Fix package json * more fixes post merge * fix the store * fix sidepanel * fix the link to explore * improve speed by parallelizing calls to gemini * fix summarization * scroll into view * add filter helper and tests * add tests * run on every commit * only use node 16 and 18 * use a filter validator * remove un-used console logs * post-merge fixes * fix tests * improve scrolling --------- Co-authored-by: Jawad Laraqui <[email protected]> Co-authored-by: Flavio Di Berardino <[email protected]>
Added case statement to handle both cleaned an uncleaned urls
* Added generate examples script and trusted dashboard table
adding more context to filter doc on dates
Adding context file on timeframes and intervals
adding import and reference for context
updating file
reverted/removed inline date and number filter documentation in useSendVertexMessage
update bucket string in terraform file for ease of sed command
…oker-explore-assistant into marketplace_deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explore Assistant for Marketplace
Purpose
Significant Changes:
Deployment Notes:
There are two related repositories, the source code repo and the LookML repo.
The LookML repo is: https://github.com/bytecodeio/explore-assistant-lookml
This Looker project repo has 3 override constants.
It is public, and it can be copied over as-is, with just 1 change (the Cloud Console link)
The source code repo is a fork of the looker-explore-assistant google repo: https://github.com/bytecodeio/looker-explore-assistant/tree/marketplace_deploy
Install includes a cloud console deployer link for the backend service. That deployer is configured to point to the ‘bytecodeio’ github organization and the marketplace_deploy branch. The code pointing to this should be changed in every readme location for it to function properly in the marketplace. It should point to the looker-open-source repo and main branch instead.
The Terraform script does not include the final security/networking steps to restrict the cloud function endpoint to Looker IPs. There are ‘manual’ instructions for that.