-
Notifications
You must be signed in to change notification settings - Fork 364
fix: null value not persisted for properties of type JSON, Any, or Ob… #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have added tests aswell. Please let me know if there is anything missing here. I'd really like to get this merged as we have many projects with this issue. |
@siimsams: Thanks. Although I proposed the fix, I had not found the time to create the tests. |
Thank you for proposing the fix. I added the tests aswell. Hope this gets approved and merged. We want to use latest versions but this issue blocks us from doing that.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siimsams, thanks for your contribution. Please see my comments. I'll take a closer look at the change later today. Thanks.
Thank you for such fast response! I have fixed the issues. |
Pull Request Test Coverage Report for Build 5324909921Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Fixed the commit message. It would be nice to have these required prefixes detailed in the pr/commit guidelines. As i could not have known about the requirement beforehand. |
@siimsams, there's still error from the commit linter
I suggest to squash the commit and have the commit message something like what you have in the title (make sure it's within 50 characters). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes LGTM. Let's get the commit linting error fixed and we can go ahead to merge. Thanks.
…ject Signed-off-by: Siim Sams <[email protected]>
Squashed everything. Should be good to go now.
Edit: |
@siimsams, thanks for your contribution. Your PR has landed! 🎉 |
Thank you so much! |
Fix the following issue on latest master.
fixes #1895
Checklist
npm test
passes on your machine