Skip to content

fix: set useDefaultIdType while discovering models #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

The juggler changes the type of the id to the default type from the connector except useDefaultIdType is set to false.
This PR enables the discoverer to add this flag when the type is available in the property.

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13883869751

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.69%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/datasource.js 1 2 50.0%
Totals Coverage Status
Change from base Build 13880427160: -0.02%
Covered Lines: 7279
Relevant Lines: 8286

💛 - Coveralls

@aaqilniz aaqilniz marked this pull request as ready for review March 16, 2025 16:11
@aaqilniz aaqilniz requested a review from dhmlau as a code owner March 16, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants