[multitop] port aes_smoketest to multitop #26242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Looks good. Just a quick comment: technically the name kDtAes is a top-specific because each top can name instances the way it wants to. Therefore if a top wanted to name is AES instance 'myaes' then the test would not compile. It's also unclear how to deal with tops with several AES blocks (if that ever happens). Therefore the "right" thing to do would probably be this:
// Pick the first AES block.
dt_aes_t kAesUnderTest = (dt_aes_t)0;
static_assert(kDtAesCount >= 1, "This test requires at least one AES instance");
Signed-off-by: Gary Guo <[email protected]>
This test does not actually use entropy_testutils, so remove the dependency and it's a simple port. Signed-off-by: Gary Guo <[email protected]>
nbdd0121
force-pushed
the
aes-multitop
branch
from
f476869 to
1fd91da
Compare
|
I think I prefer to keep using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26208
Fix #26209
Fix #26210