fix handleTOPIC only supporting modern RPL_TOPIC #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handleTOPIC was using the wrong event parameters when a TOPIC message or (old) RPL_TOPIC was received, it only handles (new) RPL_TOPIC messages correctly. TOPIC messages are defined as `TOPIC <channel> [:<topic>]` in both specs while RPL_TOPIC differs between RFC1459/RFC2812 and "Modern IRC" such that they are respectively defined as `RPC_TOPIC <channel> :<topic>` and `RPL_TOPIC <client> <channel> :<topic>`. The old code only correctly parsed the "Modern IRC" RPL_TOPIC variant and not the (old) RPL_TOPIC or TOPIC events, these were instead silently never used in state tracking of the channel topic.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 53.52% 54.16% +0.64%
==========================================
Files 16 16
Lines 2741 3641 +900
==========================================
+ Hits 1467 1972 +505
- Misses 1149 1544 +395
Partials 125 125 ☔ View full report in Codecov by Sentry. |
lrstanley
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Changes proposed by this PR
handleTOPIC was using the wrong event parameters when a TOPIC message or (old) RPL_TOPIC was received, it only handles (new) RPL_TOPIC messages correctly.
TOPIC messages are defined as
TOPIC <channel> [:<topic>]in both specs while RPL_TOPIC differs between RFC1459/RFC2812 and "Modern IRC" such that they are respectively defined asRPL_TOPIC <channel> :<topic>andRPL_TOPIC <client> <channel> :<topic>.The old code only correctly parsed the "Modern IRC" RPL_TOPIC variant and not the (old) RPL_TOPIC or TOPIC events, these were instead silently never used in state tracking of the channel topic.
🧰 Type of change
🤝 Requirements