-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Selectable Approaches for Text (Chain of Thought with Prompt Chaining) #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/text/module_text_llm/module_text_llm/approaches/approach_config.py
Outdated
Show resolved
Hide resolved
modules/text/module_text_llm/module_text_llm/approaches/basic_approach/config.py
Outdated
Show resolved
Hide resolved
...xt/module_text_llm/module_text_llm/approaches/basic_approach/prompts/generate_suggestions.py
Outdated
Show resolved
Hide resolved
modules/text/module_text_llm/module_text_llm/approaches/chain_of_thought_approach/config.py
Outdated
Show resolved
Hide resolved
modules/text/module_text_llm/module_text_llm/approaches/approach_config.py
Outdated
Show resolved
Hide resolved
...module_text_llm/module_text_llm/approaches/chain_of_thought_approach/generate_suggestions.py
Outdated
Show resolved
Hide resolved
FelixTJDietrich
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure and code looks good now.
We will have to fix the playground issue in a follow-up
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR provides a new structure for different approaches within the text llm module. It already adds a new approach "chain of thought".
Description
The standard approach has been moved in a folder named basic_approach. Each approach has its own folder so they can be easily added, or deleted in case it is not needed anymore. The approach controller and config need to be adjusted when a new approach is added or removed.
Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Screenshots