Allow mods and games to provide translations for settings#16865
Draft
y5nw wants to merge 1 commit intoluanti-org:masterfrom
Draft
Allow mods and games to provide translations for settings#16865y5nw wants to merge 1 commit intoluanti-org:masterfrom
y5nw wants to merge 1 commit intoluanti-org:masterfrom
Conversation
y5nw
added
@ Translation
Feature ✨
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9070.
The
settingobject now has optional information on the source of the setting. This can be used to find the mod that the setting belongs to. The translation domain is selected from the source mod;gettextis used otherwise if the source is not provided.No.
To do
Out of scope: CSMs currently cannot provide their own translation files; settings from CSMs are therefore not translated.
How to test
TBD