Open
Conversation
Contributor
|
This is wayy too prominent. If you think about when it's needed - someone joining your game - then just the pause menu should have this imo |
Author
Maybeit should only be displayed in the menu where you create/join a world ? |
Contributor
|
I don't really mind the IP address in the main menu but it should definitely be shown in the pause menu. Since it's now enabled by default, does this work with IPv6 only? It should probably show a non-link-local one (ULA?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15927
Add compact, short information about your PR for easier understanding:
Goal of the PR: Display the player's local IP address in the top-left corner of the main menu to facilitate LAN multiplayer.
How does the PR work ? :
Does it resolve any reported issue ?:
Yes, resolves #15927 (#15927).
Does this relate to a goal in the roadmap?:
Not directly, but it improves the general User Experience (UX) for multiplayer networking.
If this PR doesn't fix a bug, why is it necessary? What use cases does it solve ?
As requested in the ticket, it simplifies hosting local network games. Players no longer need to open a terminal or dig through operating system settings to find their local IP address; it's now directly visible on the home screen.
To do
This PR is a Ready for Review.
How to test
1 - Compile the Luanti engine on a Linux or macOS machine.
2 - Launch the game.
3 - On the main menu screen, look at the top-left corner (under the Luanti version and debug text).
4 - You should see IP Locale: [Your Local Network IP] (e.g., 192.168.1.50).
5 - Ensure it does not display 127.0.0.1.