fix: Resolve subprocess import error in perform_import() #16#19
Open
nishair wants to merge 1 commit intolucafon:masterfrom
Open
fix: Resolve subprocess import error in perform_import() #16#19nishair wants to merge 1 commit intolucafon:masterfrom
nishair wants to merge 1 commit intolucafon:masterfrom
Conversation
- Add missing 'import subprocess' to SqoopImport.py - The perform_import() method uses subprocess.PIPE but only had 'from subprocess import call, run' - This caused "name 'subprocess' is not defined" NameError when calling perform_import() - Add comprehensive unit test to verify perform_import() and perform_export() work correctly - Test ensures methods return proper types (CompletedProcess or int) without NameError Fixes issue lucafon#16 where users encountered subprocess NameError when using sqoop.perform_import()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #16 where users encountered subprocess NameError when using sqoop.perform_import()