forked from MohitShridhar/rviz_textured_quads
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to dynamically change what image topic the mesh is subscribed to #11
Open
PaperFanz
wants to merge
36
commits into
lucasw:master
Choose a base branch
from
UTNuclearRobotics:image_topic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t necessary and should be separated out
…other with remainder until other major changes are made.
… able to start a fresh rviz and get it working (where loading the saved rviz config wasn't working)
…verything I want it to. However, I'd like to clean up the code a lot- I made a stashed attempt to get rid of the std::vectors, but the result was crashing. Also I think the method of creating the quad and projecting the texture is not optimal, so that deserves some looking at.
… in one step haven't been successful
…lucasw#3, but it didn't work- maybe that should be pre-render target instead?
… so don't try to install it
…maybe should encapsulate all of demo.launch here.
… based on a string topic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented a change that allows for users to select an 'Image Topic Selector' Topic that publishes std_msgs::Strings which are the new Image Topic to subscribe to, allowing us to assign a hotkey with which to switch between multiple camera views for a single mesh. When the string "transparent" is passed, it will make the whole mesh transparent.
This feature does not affect any previous functionality, as the default is empty. However, we believe that this is a simple feature a significant number of users could benefit from.