Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for custom recipes? #38

Open
SageofTurtles opened this issue Nov 14, 2024 · 7 comments
Open

Documentation for custom recipes? #38

SageofTurtles opened this issue Nov 14, 2024 · 7 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@SageofTurtles
Copy link

SageofTurtles commented Nov 14, 2024

Hello! I'm trying to add this mod to my custom modpack (which I'm very excited to include!), and want to change some of the recipes using the Beam Focuser. I thought I could do this with a .json file, same as a datapack, but I can't find any documentation on how to do that with this particular recipe type, or what different values/strings can be used for that. In particular, I'm wanting to remove the 10% chance of outputting charcoal when using the focusing recipes to color items, but those recipes seem to be auto-populating from existing dye coloring recipes, so I can't even find examples to reference for those changes. Would you be able to provide or point me to some documentation for making those changes, or adding my own recipes of this type? Thanks in advance!

@IlBudda
Copy link

IlBudda commented Dec 30, 2024

Did you find anything? I'm trying to implement assembly with different waves but I can't

@SageofTurtles
Copy link
Author

Did you find anything? I'm trying to implement assembly with different waves but I can't

Unfortunately not, there doesn't seem to be any information out there about these recipes types, so I'm at a dead end as well until the author of this mod responds with more info.

@luccaPossamai
Copy link
Owner

I'm sorry I've made you wait. That recipe system is just a pain in the stomach. These recipes you mentioned are hard coded in the mod, just like some create mod recipes(fan ones I think). There's a line in the code that permit addon creators to override these recipes, I guess. If you want to override all of 'em make use of the tags, that way maybe you can change those.

@luccaPossamai
Copy link
Owner

About documentation, no there's no documentation about the recipes. All I got for now is an example, which you probably already seen.

At this dir there's the recipes added by the mod, for now there's only one
master/src/generated/resources/data/create_optical/recipes/focusing

And for the assembly recipes, see about the rose_quartz coil at
master/src/generated/resources/data/create_optical/recipes/sequenced_assembly

@luccaPossamai
Copy link
Owner

As mentioned in #39, this json format requires the enum id of the beam type, you can see more about it here:
master/src/main/java/net/lpcamors/optical/recipes/FocusingRecipeParams.java
But, for simplicity there's the codes:
RADIO: 0
MICROWAVE: 1
VISIBLE: 2
GAMMA: 3
ANY: 4

Obs.: for the sequenced assembly recipes, the beam type does not show in JEI, that's intentioned. I'll fixed it.

@luccaPossamai luccaPossamai added documentation Improvements or additions to documentation question Further information is requested labels Jan 8, 2025
@SageofTurtles
Copy link
Author

Thanks for the info! That will certainly be helpful.

There's a line in the code that permit addon creators to override these recipes, I guess. If you want to override all of 'em make use of the tags, that way maybe you can change those.

Could you maybe clarify what you mean by "tags" here? I'm not sure which tag(s) the mod is looking for when populating those recipes. If it can be done by changing a few tags, that would be immensely simpler than re-writing hundreds of auto-populated recipes.

@luccaPossamai
Copy link
Owner

The item tags, more like minecraft:glass_panes, etc. I've just see that the recipe builders are hard coded, I tried to use some "dyable" for items that could be dyed but don't think that exists. If so you could try it(create a generic recipe for dyable items). But I think these coloring recipes are builtin inside the minecraft code or manually. In the worst case scenario you really could override all of them, but that's not applicable for modpacks(unless you override these recipes mod by mod). To enhance this feature I could add some configuration by the user by config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants