feat: defention of done

[jguddas]

• = Reviewer
• 🐙 = Contributor
• 🤖 = GitHub workflow

I have thought of everything:

• Elements have at least 1 pixel padding within the canvas. (:robot:)
• Icons are visually centered. (:octocat: and maybe :robot: https://github.com/mapbox/polylabel)
• Icons have a similar optical volume as circle and square. (:octocat: and maybe :robot: with convex hull)
• Icons have similar visual density and level of detail. (:octocat: and maybe :robot:, could just use total line length)
• Icons are fun and playful. (:octopus: & :octocat:)
• Elements and Arcs centers align with the grid. (:robot:)
• Corners have a 2px radius or have a good reason for sharpness. (:octopus:)
• Holes and gaps only become invisible with stroke widths of at least 4px. (:robot:)
• Gaps are closed, so they are 2px when possible.(:octocat:) feat: defention of done #1224 (comment)
• Curves join smoothly. (:octocat:) https://www.figma.com/community/plugin/932729267119671976/Curvature
• Icon is at most based on other lucide icon and not on other people's work (:octopus:)
• Icon should not be a rotated or mirrored version of an already existing icon (:octopus: & :octocat:)
• Icons that are part of a group are named group-type so, for example, badge-plus is based on badge.
• Icons are named by what they are rather than their use case, for example save should rather be named to floppy-disk.
• Icons do not end with a number like -2, -3, -4, etc.
• Icons do not represent a brand or logo
• Icons are sharp on low dpi displays
• Icons have a specific use case that is not currently covered by another icon (please explain what this icon is used for, the more use cases the better)
• Icons do not include religious or political imagery
• Icons do not contain hate symbols
• Reuse shapes cross icons

I have optimized everything:

• Arc path segments are used in place of curves when possible. (:octocat:, should be :robot:, sadly currently flaky)
• circle and rect are used instead of path when possible. (:robot:)
• path is used instead of polyline, line and polygon. (:robot:)
• Paths only contain one move segment. (:robot:)
• Dots use M{{x}} {{y}}h0.01. (:robot:)

[vercel]

@jguddas is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

[jguddas]

What about making closing this kind of gap a guideline @danielbayley @karsa-mistmere @ericfennis ?

simplescreenrecorder-2023-05-07_15.21.47.mp4

[jguddas]

We should also add some rules for arrows.

[karsa-mistmere]

Thorough as this is, I feel like it might disencourage and alienate a number of potential future contributors who might be really good at design but not expert at writing SVG code. 🤔

Most of these parts could be repurposed as a reviewers' checklist maybe?

[jguddas]

Good point, we should split things up into:

• Checklist for reviewer.
• Checklist for contributor.
• Checks we automate and put into a GitHub workflow.

Edit: added some annotations to the PR description.

[jguddas]

Variations of icons are named name-variation so, i.e. badge-plus is a variation of the badge icon.

[airone01]

@jguddas we might want to debate adding the two rules from #1336 here. I'll remove my issue so it doesn't bloat the issue list ❤️.
The two rules are:

• Icons must not be branded (link to We're not accepting new Brand icons #670) in the list
• Icons uses must not be too specific in the list

[danielbayley]

• M{{x}} {{y}}h0.01. (🤖)

@jguddas Shouldn’t that be M{{x}} {{y}}h.01?