Fix an error in the docs that left me confused for a good half an hour#13
Open
markonius wants to merge 2 commits into
Open
Fix an error in the docs that left me confused for a good half an hour#13markonius wants to merge 2 commits into
markonius wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An argument is missing in the
Constraintconstructor, which leaves the strength to be interpreted as the rhs of the constraint. It left me bamboozled for a while until I noticed that difference between the API docs and the CodePen demo.Also, the docs say the default
maxIterationsis 10,000. I changed the number to match the docs (perhaps I should have changed the docs?).I hope this is OK. Have a nice day!