Skip to content

Conversation

@scossu
Copy link

@scossu scossu commented Jul 14, 2025

Fixes #461.

I noticed a few issues with dir.clonetree:

  1. The base path for the destination is incorrect.
  2. The function does not iterate through sub-folders to be cloned.
  3. As a consequence of 2, files are also not processed and copied correctly.

This PR attempt to fix these issues.

NOTE the updated description of path2. I wasn't able to verify if this was the intended behavior, since I could not get the cloning to work in the right path and the description did not specify details.

@scossu
Copy link
Author

scossu commented Sep 14, 2025

Hi there. I have been using my branch with this fix for a few months with different scenarios now, but the automated tests in this PR won't pass. I can't trace back the /srv/app/.luarocks/lib/luarocks/rocks-5.4/pocket_archive/scm-1/templates/assets error message. Can someone take a look and help merge this into the mainline? Thanks.

@scossu
Copy link
Author

scossu commented Nov 4, 2025

Hi there, apologies for the long time it took me to fix the tests - they are passing now, but the Luajit builds are failing, apparently for unrelated reason. Anyone able to chime in?

@scossu
Copy link
Author

scossu commented Nov 30, 2025

Hi, is there anything blocking this PR? If not, if someone could merge it and cut a new release, I could use the new version on a project that depends on this fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

unexpected behavior for dir.clonetree

1 participant