Conversation
Set chunking defaults to TARGET_WORDS=512 and MAX_WORDS=1024 to lower embedding memory pressure on MPS. Remove SearchService alias methods chunk_document and synchronize_document_chunks, and update tests/callers to canonical embedding APIs. Archive the completed OpenSpec change for chunk-limit tuning and alias removal. BREAKING CHANGE: SearchService no longer provides chunk_document or synchronize_document_chunks; use embed_document_chunks and synchronize_document_embeddings instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set chunking defaults to TARGET_WORDS=512 and MAX_WORDS=1024 to lower embedding memory pressure on MPS. Remove SearchService alias methods chunk_document and synchronize_document_chunks, and update tests/callers to canonical embedding APIs.
Archive the completed OpenSpec change for chunk-limit tuning and alias removal.
BREAKING CHANGE: SearchService no longer provides chunk_document or synchronize_document_chunks; use embed_document_chunks and synchronize_document_embeddings instead.