Add vrf parameter for routed-nic devices
#1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I now also tested it with VMs and it works fine. @stgraber Any chance to get this merged? |
|
@ibot3 yeah, looking at it now. I've been traveling for the past two weeks so haven't been able to do all that much review. |
stgraber
force-pushed
the
routed-nic-vrf
branch
2 times, most recently
from
f06e061 to
43db3ac
Compare
Signed-off-by: Stéphane Graber <[email protected]>
stgraber
force-pushed
the
routed-nic-vrf
branch
from
43db3ac to
fb3dd61
Compare
stgraber
approved these changes
Feb 11, 2025
stgraber
force-pushed
the
routed-nic-vrf
branch
from
fb3dd61 to
5b2bb6b
Compare
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Jakob Mueller <[email protected]>
Signed-off-by: Jakob Mueller <[email protected]>
Signed-off-by: Jakob Mueller <[email protected]>
Signed-off-by: Jakob Mueller <[email protected]>
Signed-off-by: Jakob Mueller <[email protected]>
stgraber
force-pushed
the
routed-nic-vrf
branch
from
5b2bb6b to
adede11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1613
I sadly did not get the test-suite to work yet but tried to test manually as good as possible.
Also testing the feature for VMs was not possible for me yet.