Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KafkaSource instead of FlinkKafkaConsumer #77

Open
wants to merge 5 commits into
base: release-2.50.0-lyft
Choose a base branch
from

Conversation

ardakuyumcu
Copy link

This pull request includes significant updates to the runners/flink module, primarily focusing on upgrading dependencies and refactoring the Kafka-related code to use updated classes and methods. The most important changes include updating the dependencies in flink_runner.gradle, refactoring the LyftFlinkStreamingPortableTranslations class to use the LyftKafkaSourceBuilder and KafkaSource, and modifying the ByteArrayWindowedValueSchema class to implement KafkaRecordDeserializationSchema.

@kjbilton
Copy link

kjbilton commented Feb 6, 2025

@ardakuyumcu i'm seeing errors when deploying a pipeline using this change, and i noticed this log -- any idea how it could be related?

@ardakuyumcu
Copy link
Author

@kjbilton I'm relatively new to the flink/beam ecosystem, but seems like perhaps the bundled Kafka client version is too old?

Our Flink version is requesting Kafka 3.2.3 here https://github.com/lyft/flink/blob/709df019f5c3a5d7945c5931d9aa3c0c70560c35/flink-connectors/flink-connector-kafka/pom.xml#L38

but might be Beam is building with an older version of Kafka? the only reference I could find (not sure if related) is to 2.4.1 here

which could explain why you're seeing NoSuchMethodError

@maghamravi any ideas?

@kjbilton would you be able to see what version of the kafka java client your container is running with?

@kjbilton
Copy link

kjbilton commented Feb 7, 2025

@kjbilton I'm relatively new to the flink/beam ecosystem, but seems like perhaps the bundled Kafka client version is too old?

Our Flink version is requesting Kafka 3.2.3 here https://github.com/lyft/flink/blob/709df019f5c3a5d7945c5931d9aa3c0c70560c35/flink-connectors/flink-connector-kafka/pom.xml#L38

but might be Beam is building with an older version of Kafka? the only reference I could find (not sure if related) is to 2.4.1 here

which could explain why you're seeing NoSuchMethodError
@maghamravi any ideas?

@kjbilton would you be able to see what version of the kafka java client your container is running with?

Ah, good catch. Yes, the logs indicate that we are using 2.4.1. I see that other apps using this source are running 3.1.0 [logs]. I'll take a look at upgrading Kafka here.

@kjbilton
Copy link

kjbilton commented Feb 7, 2025

Upgrading to 3.1.0 appears to be running fine -- going to take a closer look to validate, but so far it all looks good! Tested here: #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants