feat: Add MPRoktEmbeddedView Class#345
Merged
BrandonStalnaker merged 1 commit intodevelopmentfrom Apr 17, 2025
Merged
Conversation
BrandonStalnaker
requested review from
Mansi-mParticle,
alexs-mparticle and
rmi22186
sahil-rokt
reviewed
Apr 15, 2025
| NSDictionary *attributes = @{@"key": @"value"}; | ||
| NSDictionary *finalAttributes = @{@"key": @"value", @"sandbox": @"true"}; | ||
| NSDictionary *placements = @{@"placement": @"test"}; | ||
| MPRoktEmbeddedView *exampleView = [[MPRoktEmbeddedView alloc] initWithFrame:CGRectZero]; |
There was a problem hiding this comment.
In Android it is called RoktEmbeddedView, should we align with the name on both the platforms ? cc: @Mansi-mParticle
Collaborator
Author
There was a problem hiding this comment.
Namespacing isn't available in Objective C or Swift so adding prefixes is the standard way of preventing naming collisions.
WeiYewT
approved these changes
Apr 16, 2025
WeiYewT
left a comment
WeiYewT
left a comment
There was a problem hiding this comment.
looks good to me, we will need to do something similar like android with injecting the RoktEmbeddedView at the kit level.
BrandonStalnaker
deleted the
feat/SQDSDKS-7200-Create-MPRoktEmbeddedView-In-Core
branch
mparticle-automation
added a commit
that referenced
this pull request
Apr 24, 2025
# [8.30.0](v8.29.0...v8.30.0) (2025-04-24) ### Features * Add disabledKits option to MParticleOptions ([#347](#347)) ([f708431](f708431)) * Add MPRoktEmbeddedView Class ([#345](#345)) ([f4fb946](f4fb946)) * Add user attribute mapping ([#343](#343)) ([50ce934](50ce934)) * Automatically include sandbox in MPRokt Attributes ([#344](#344)) ([bdf4280](bdf4280))
Contributor
|
🎉 This PR is included in version 8.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)