Skip to content

feat: Implement MPRoktEventCallback on Core#348

Merged
BrandonStalnaker merged 5 commits intodevelopmentfrom
feat/SQDSDKS-7226-Implement-MPEventCallback-on-Core
Apr 29, 2025
Merged

feat: Implement MPRoktEventCallback on Core#348
BrandonStalnaker merged 5 commits intodevelopmentfrom
feat/SQDSDKS-7226-Implement-MPEventCallback-on-Core

Conversation

@BrandonStalnaker
Copy link
Copy Markdown
Collaborator

Summary

  • Moved MPRokt code out into its own class and replaced individual callbacks with

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested using sample app and confirmed succesfull placement along with smoke testing of core.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Apr 23, 2025
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SQDSDKS-7226-Implement-MPEventCallback-on-Core branch from cfca5d7 to f6171fe Compare April 23, 2025 16:23
@BrandonStalnaker
Copy link
Copy Markdown
Collaborator Author

So the main changes to this (outside of me moving MPRokt out into its own class)

  1. Add a MPRoktEventCallback class that has a property for each callback offered on the Rokt SDK selectPlacement.
  2. Update MPKitProtocols selectPlacement method to take MPRoktEventCallback as a parameter
  3. Update any place that was using that old method or its selector. (MPRokt, MPRoktTests, and KitContainer mostly)

@BrandonStalnaker BrandonStalnaker force-pushed the feat/SQDSDKS-7226-Implement-MPEventCallback-on-Core branch from 05d00bc to cc384aa Compare April 28, 2025 13:11
@BrandonStalnaker BrandonStalnaker merged commit d5fd11d into development Apr 29, 2025
12 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-7226-Implement-MPEventCallback-on-Core branch April 29, 2025 16:59
mparticle-automation added a commit that referenced this pull request Apr 29, 2025
## [8.30.2](v8.30.1...v8.30.2) (2025-04-29)

### Bug Fixes

* Implement MPRoktEventCallback on Core ([#348](#348)) ([d5fd11d](d5fd11d))
@mparticle-automation
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 8.30.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants