Skip to content

fix: Update placementAttributes to placementAttributesMapping#349

Merged
BrandonStalnaker merged 1 commit intodevelopmentfrom
feat/SQDSDKS-7240-Update-Setting-Name-To-placementAttributesMapping
Apr 24, 2025
Merged

fix: Update placementAttributes to placementAttributesMapping#349
BrandonStalnaker merged 1 commit intodevelopmentfrom
feat/SQDSDKS-7240-Update-Setting-Name-To-placementAttributesMapping

Conversation

@BrandonStalnaker
Copy link
Copy Markdown
Collaborator

Summary

  • Update the constant expected from the server to be the more accurate name.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Ran all unit tests fine and built and ran fine

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Copy Markdown
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making it a constant is an improvement!

@BrandonStalnaker BrandonStalnaker merged commit 13ec6a2 into development Apr 24, 2025
9 of 12 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-7240-Update-Setting-Name-To-placementAttributesMapping branch April 24, 2025 20:42
mparticle-automation added a commit that referenced this pull request Apr 24, 2025
## [8.30.1](v8.30.0...v8.30.1) (2025-04-24)

### Bug Fixes

* Update placementAttributes to placementAttributesMapping ([#349](#349)) ([13ec6a2](13ec6a2))
@mparticle-automation
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 8.30.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants