Skip to content

fix: assign correct IDFV instead of random UUID #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrandonStalnaker merged 1 commit into from
May 2, 2025
Merged

fix: assign correct IDFV instead of random UUID #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mParticle-Apple-SDK/Utils/MPDevice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ import CoreTelephony
if let vendor = userDefaults[Device.kMPDeviceAppVendorIdKey] as? String, vendor != Device.kMPDeviceInvalidVendorId {
_vendorId = vendor
} else {
_vendorId = UUID().uuidString
_vendorId = UIDevice.current.identifierForVendor?.uuidString
userDefaults[Device.kMPDeviceAppVendorIdKey] = _vendorId
Copy link
Copy Markdown
Collaborator

@BrandonStalnaker BrandonStalnaker May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heres the old functionality to compare this more easily. I think this is the correct fix comparing these

}
}
return _vendorId
Expand Down