feat: Migrate MPResponseConfigTests by denischilik · Pull Request #552 · mParticle/mparticle-apple-sdk

denischilik · 2026-02-04T18:47:52Z

Background

We also need to migrate tests related to migrated swift target

What Has Changed

MPResponseConfigTests was migrated to SwiftTests target
some tests were moved to MPUserDefaultsTest because they tested his functionality

Screenshots/Video

{Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

I have performed a self-review of my own code.
I have made corresponding changes to the documentation.
I have added tests that prove my fix is effective or that my feature works.
I have tested this locally.

Additional Notes

{Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

Closes https://rokt.atlassian.net/browse/SDKE-830

…nRestore

github-actions · 2026-02-04T18:52:17Z

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric	Target Branch	This PR	Change
App Bundle Impact	1.60 MB	1.60 MB	+N/A
Executable Impact	896 bytes	896 bytes	+N/A
XCFramework Size	5.38 MB	5.38 MB	+N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1724,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1640,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5504}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1724,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1640,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5504}

BrandonStalnaker

Just a minor typo that got spread to few places. Looks good otherwise.

mParticle-Apple-SDK-Swift/Test/Mocks/MPUserDefaultsConnectorMock.swift

mParticle-Apple-SDK-Swift/Test/Utils/MPResponseConfigTests.swift

…ck.swift Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

nickolas-dimitrakas

LGTM

…nfigTests-cp

…m-main * workstation/9.0-Release: (31 commits) feat: Update Rokt public methods to match Rokt 5.0 (#521) feat: Expose MPDateFormatter to kits (#564) feat: Remove NoLocation suffix (#563) feat: Migrate MPResponseConfigTests (#552) chore: Add additional unit tests for v9 (#557) feat: Source Based Distribution (#556) feat: Migrate MPUserDefaultTests (#550) feat: Migrate MPUserDefaults (#545) ci: add swift scheme (#544) feat: Migrate mp upload settings convert to objc updated (#543) refactor: Migrate MPRoktEvent (#538) refactor: migrate SceneDelegateHandler to objc (#539) refactor: migrate mp convert js to objc (#537) feat: Migrate MPDevice to swift target (#535) refactor: Convert MPPersistenceController to Obj C (#529) feat: Move swift files to separate swift target part 3 (#528) revert: expandedInstructions return type (#532) refactor: migrate MPSideloadedKit to objc (#530) feat: direct routing by default (#508) feat: Move swift files to separate swift target part 2 (#527) ... # Conflicts: # .github/workflows/sdk-release-manual.yml # .github/workflows/size-report.yml # CHANGELOG.md # Framework/Info.plist # IntegrationTests/Sources/main.swift # IntegrationTests/wiremock-recordings/mappings/mapping-ccpa-consent.json # IntegrationTests/wiremock-recordings/mappings/mapping-commerce-event-purchase.json # IntegrationTests/wiremock-recordings/mappings/mapping-gdpr-consent.json # IntegrationTests/wiremock-recordings/mappings/mapping-increment-session-attribute-ss.json # IntegrationTests/wiremock-recordings/mappings/mapping-increment-session-attribute.json # IntegrationTests/wiremock-recordings/mappings/mapping-increment-user-attribute-set.json # IntegrationTests/wiremock-recordings/mappings/mapping-increment-user-attribute.json # IntegrationTests/wiremock-recordings/mappings/mapping-log-error.json # IntegrationTests/wiremock-recordings/mappings/mapping-log-event-with-flags.json # IntegrationTests/wiremock-recordings/mappings/mapping-log-exception.json # IntegrationTests/wiremock-recordings/mappings/mapping-log-screen.json # IntegrationTests/wiremock-recordings/mappings/mapping-rokt-identify.json # IntegrationTests/wiremock-recordings/mappings/mapping-rokt-select-placement.json # IntegrationTests/wiremock-recordings/mappings/mapping-set-att-status.json # IntegrationTests/wiremock-recordings/mappings/mapping-set-session-attribute.json # IntegrationTests/wiremock-recordings/mappings/mapping-set-user-attributes.json # IntegrationTests/wiremock-recordings/mappings/mapping-timed-event.json # IntegrationTests/wiremock-recordings/mappings/mapping-v1-identify.json # IntegrationTests/wiremock-recordings/mappings/mapping-v2-events-log-event.json # IntegrationTests/wiremock-recordings/mappings/mapping-v4-config-get-config.json # Package.swift # Tests/SizeReport/LocalSDK/Package.swift # Tests/SizeReport/SizeTestAppWithSDK/SizeTestAppWithSDK/ContentView.swift # UnitTests/ObjCTests/MPRoktTests.m # UnitTests/SwiftTests/MParticle/MParticleOpenURLTests.swift # UnitTests/SwiftTests/MParticle/MParticleUserActivityTests.swift # mParticle-Apple-SDK-Swift/Sources/Utils/MPUserDefaults.swift # mParticle-Apple-SDK.podspec # mParticle-Apple-SDK/MPBackendController.m # mParticle-Apple-SDK/MPConstants.swift # mParticle-Apple-SDK/MPIConstants.m # mParticle-Apple-SDK/MPRokt.m # mParticle-Apple-SDK/Network/MPNetworkCommunication.m # mParticle-Apple-SDK/SceneDelegateHandler.swift # mParticle-Apple-SDK/Utils/MPResponseConfig.swift # mParticle-Apple-SDK/mParticle.m # mParticle_Apple_SDK.json

denischilik added 9 commits February 4, 2026 13:20

feat: Just move test file to swift target

5510e97

Convert testIgnoresLegacyDirectRoutingConfig

3ab3c18

Migrate testDeleteDueToMaxConfigAge

e2c9b37

Migrate testShouldDeleteDueToMaxConfigAge

0f6683b

Migrate testShouldDeleteDueToMaxConfigAgeWhenNil

9c173cb

migrate testSaveRestore

3abbef6

Migrate testInvalidConfigurations and testUpdateCustomModuleSettingsO…

5164177

…nRestore

Migrate testInstance

408c0b5

Address linter issues

ec5f2f6

denischilik changed the base branch from main to workstation/9.0-Release February 4, 2026 18:48

Initialize connector in setup method

7b16781

denischilik marked this pull request as ready for review February 4, 2026 20:04

denischilik requested a review from a team as a code owner February 4, 2026 20:04

denischilik requested review from BrandonStalnaker, jamesnrokt and nickolas-dimitrakas February 4, 2026 20:04

BrandonStalnaker requested changes Feb 4, 2026

View reviewed changes

denischilik and others added 6 commits February 5, 2026 07:36

Update mParticle-Apple-SDK-Swift/Test/Mocks/MPUserDefaultsConnectorMo…

1e01700

…ck.swift Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

Update mParticle-Apple-SDK-Swift/Test/Mocks/MPUserDefaultsConnectorMo…

2ddb2e3

…ck.swift Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

Update mParticle-Apple-SDK-Swift/Test/Utils/MPResponseConfigTests.swift

e2310dc

Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

Update mParticle-Apple-SDK-Swift/Test/Utils/MPResponseConfigTests.swift

0a54e80

Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

Update mParticle-Apple-SDK-Swift/Test/Utils/MPResponseConfigTests.swift

fc90039

Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>

Remove spaces

05806e2

nickolas-dimitrakas approved these changes Feb 5, 2026

View reviewed changes

Merge branch 'workstation/9.0-Release' into feat/Migrate_MPResponseCo…

94e4758

…nfigTests-cp

BrandonStalnaker approved these changes Feb 5, 2026

View reviewed changes

nickolas-dimitrakas approved these changes Feb 5, 2026

View reviewed changes

denischilik merged commit 5e1008c into workstation/9.0-Release Feb 6, 2026
17 of 18 checks passed

denischilik deleted the feat/Migrate_MPResponseConfigTests-cp branch February 6, 2026 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migrate MPResponseConfigTests#552

feat: Migrate MPResponseConfigTests#552
denischilik merged 17 commits intoworkstation/9.0-Releasefrom
feat/Migrate_MPResponseConfigTests-cp

denischilik commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

BrandonStalnaker left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickolas-dimitrakas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

denischilik commented Feb 4, 2026

Background

What Has Changed

Screenshots/Video

Checklist

Additional Notes

Reference Issue (For employees only. Ignore if you are an outside contributor)

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 SDK Size Impact Report

Uh oh!

BrandonStalnaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 4, 2026 •

edited

Loading