Skip to content

feat: Remove NoLocation suffix#563

Merged
denischilik merged 5 commits intoworkstation/9.0-Releasefrom
feat/Remove-no-location-suffix
Feb 9, 2026
Merged

feat: Remove NoLocation suffix#563
denischilik merged 5 commits intoworkstation/9.0-Releasefrom
feat/Remove-no-location-suffix

Conversation

@denischilik
Copy link
Copy Markdown
Contributor

@denischilik denischilik commented Feb 9, 2026

Background

Since location related functionality was removed from mParticle-Apple-SDK there is no needs to support name with NoLocation suffix

What Has Changed

  • Target name was updated
  • All scripts were updated
  • All import were updated

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@denischilik denischilik force-pushed the feat/Remove-no-location-suffix branch from fcba3f4 to 1dd8432 Compare February 9, 2026 14:24
@denischilik denischilik force-pushed the feat/Remove-no-location-suffix branch from 1dd8432 to ed970f3 Compare February 9, 2026 14:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.60 MB 1.60 MB +N/A
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 5.38 MB 5.38 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1724,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1640,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5504}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1724,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1640,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5504}

@denischilik denischilik marked this pull request as ready for review February 9, 2026 15:29
@denischilik denischilik requested a review from a team as a code owner February 9, 2026 15:29
Copy link
Copy Markdown
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small thing. Everything else looks great!

jamesnrokt
jamesnrokt previously approved these changes Feb 9, 2026
denischilik and others added 2 commits February 9, 2026 11:03
denischilik and others added 2 commits February 9, 2026 11:04
Co-authored-by: James Newman <james.newman@rokt.com>
…Particle/mparticle-apple-sdk into feat/Remove-no-location-suffix

* 'feat/Remove-no-location-suffix' of https://github.com/mParticle/mparticle-apple-sdk:
  Update README.md
  Update README.md
@denischilik denischilik merged commit 37a9f17 into workstation/9.0-Release Feb 9, 2026
27 of 38 checks passed
@denischilik denischilik deleted the feat/Remove-no-location-suffix branch February 9, 2026 18:54
denischilik added a commit that referenced this pull request Feb 10, 2026
…m-main

* workstation/9.0-Release: (31 commits)
  feat: Update Rokt public methods to match Rokt 5.0 (#521)
  feat: Expose MPDateFormatter to kits (#564)
  feat: Remove NoLocation suffix (#563)
  feat: Migrate MPResponseConfigTests (#552)
  chore: Add additional unit tests for v9 (#557)
  feat: Source Based Distribution (#556)
  feat: Migrate MPUserDefaultTests (#550)
  feat: Migrate MPUserDefaults (#545)
  ci: add swift scheme (#544)
  feat: Migrate mp upload settings convert to objc updated  (#543)
  refactor: Migrate MPRoktEvent (#538)
  refactor: migrate SceneDelegateHandler to objc (#539)
  refactor: migrate mp convert js to objc (#537)
  feat: Migrate MPDevice to swift target (#535)
  refactor: Convert MPPersistenceController to Obj C (#529)
  feat: Move swift files to separate swift target part 3 (#528)
  revert: expandedInstructions return type (#532)
  refactor: migrate MPSideloadedKit to objc (#530)
  feat: direct routing by default (#508)
  feat: Move swift files to separate swift target part 2 (#527)
  ...

# Conflicts:
#	.github/workflows/sdk-release-manual.yml
#	.github/workflows/size-report.yml
#	CHANGELOG.md
#	Framework/Info.plist
#	IntegrationTests/Sources/main.swift
#	IntegrationTests/wiremock-recordings/mappings/mapping-ccpa-consent.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-commerce-event-purchase.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-gdpr-consent.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-session-attribute-ss.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-session-attribute.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-user-attribute-set.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-user-attribute.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-error.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-event-with-flags.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-exception.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-screen.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-rokt-identify.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-rokt-select-placement.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-set-att-status.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-set-session-attribute.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-set-user-attributes.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-timed-event.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-v1-identify.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-v2-events-log-event.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-v4-config-get-config.json
#	Package.swift
#	Tests/SizeReport/LocalSDK/Package.swift
#	Tests/SizeReport/SizeTestAppWithSDK/SizeTestAppWithSDK/ContentView.swift
#	UnitTests/ObjCTests/MPRoktTests.m
#	UnitTests/SwiftTests/MParticle/MParticleOpenURLTests.swift
#	UnitTests/SwiftTests/MParticle/MParticleUserActivityTests.swift
#	mParticle-Apple-SDK-Swift/Sources/Utils/MPUserDefaults.swift
#	mParticle-Apple-SDK.podspec
#	mParticle-Apple-SDK/MPBackendController.m
#	mParticle-Apple-SDK/MPConstants.swift
#	mParticle-Apple-SDK/MPIConstants.m
#	mParticle-Apple-SDK/MPRokt.m
#	mParticle-Apple-SDK/Network/MPNetworkCommunication.m
#	mParticle-Apple-SDK/SceneDelegateHandler.swift
#	mParticle-Apple-SDK/Utils/MPResponseConfig.swift
#	mParticle-Apple-SDK/mParticle.m
#	mParticle_Apple_SDK.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants