feat: RoktContracts POC Core Changes#675
feat: RoktContracts POC Core Changes#675BrandonStalnaker wants to merge 5 commits intoworkstation/9.0-Releasefrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| callbacks.onShouldHideLoadingIndicator = { | ||
| // Optional callback to hide a loading indicator | ||
| } | ||
| callbacks.onEmbeddedSizeChange = { _, size in |
There was a problem hiding this comment.
Unused heightBinding parameter breaks embedded placement visibility
High Severity
The selectEmbeddedPlacement function accepts a heightBinding parameter but never uses it. Previously, the onEmbeddedSizeChange callback updated heightBinding.wrappedValue with the new size. Now the onEvent closure is empty. Since the UI only shows the RoktEmbeddedViewWrapper when roktViewHeight > 0 (line 34), the embedded placement will never become visible because roktViewHeight is never updated from its initial value of 0. The same issue applies to the ObjC example where onEvent is empty and [self setupUI:size] is never called.
Additional Locations (1)
Package.swift
Outdated
| ) | ||
| ], | ||
| dependencies: [ | ||
| .package(path: "../ROKT/rokt-contracts-apple") |
There was a problem hiding this comment.
Local filesystem path dependency in Package.swift
High Severity
The SPM dependency .package(path: "../ROKT/rokt-contracts-apple") references a local filesystem path. This will fail for any consumer resolving this package via SPM, any CI pipeline, or any developer who doesn't have that exact directory structure alongside their checkout. The core SDK's public headers (MPRokt.h, MPKitProtocol.h) now contain @import RoktContracts;, making this a hard build-breaking dependency for all integration methods.
7b0edb6 to
d5d1261
Compare


DRAFT
Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)