Skip to content

revert: "ci: cache SPM packages and add timeout in release-publish build-kits (#719)"#722

Merged
nickolas-dimitrakas merged 3 commits intomainfrom
revert/pr-719
Apr 8, 2026
Merged

revert: "ci: cache SPM packages and add timeout in release-publish build-kits (#719)"#722
nickolas-dimitrakas merged 3 commits intomainfrom
revert/pr-719

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Apr 8, 2026

Summary

Reverts #719.

  • Removes SPM package caching step from the build-kits job in release-publish.yml
  • Removes -derivedDataPath and -packageCachePath flags from xcodebuild archive commands

Test plan

  • CI passes on this PR
  • release-publish workflow runs without the caching steps

🤖 Generated with Claude Code

@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner April 8, 2026 14:38
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 8, 2026

PR Summary

Medium Risk
Changes the release-publish workflow’s kit build process, which could impact release build performance and reliability (e.g., longer builds or different dependency resolution behavior). No product/runtime code is modified.

Overview
Reverts the release-publish.yml build-kits job back to building kits without explicit Swift Package Manager caching or pre-resolving dependencies.

Removes the actions/cache step for DerivedData/SourcePackages, drops the xcodebuild -resolvePackageDependencies step, and eliminates -derivedDataPath/-packageCachePath usage from the kit xcodebuild archive commands.

Reviewed by Cursor Bugbot for commit 0767898. Bugbot is set up for automated code reviews on this repo. Configure here.

@nickolas-dimitrakas nickolas-dimitrakas changed the title Revert "ci: cache SPM packages and add timeout in release-publish build-kits (#719)" revert: "ci: cache SPM packages and add timeout in release-publish build-kits (#719)" Apr 8, 2026
@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Apr 8, 2026
@nickolas-dimitrakas nickolas-dimitrakas merged commit 819d1a6 into main Apr 8, 2026
3 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the revert/pr-719 branch April 8, 2026 14:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.75 MB 1.75 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.38 MB 6.38 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants