ci: add publish-cocoapods job to release-publish workflow#723
ci: add publish-cocoapods job to release-publish workflow#723nickolas-dimitrakas merged 3 commits intomainfrom
Conversation
PR SummaryMedium Risk Overview Updates Reviewed by Cursor Bugbot for commit 2d3e273. Bugbot is set up for automated code reviews on this repo. Configure here. |
ed23088 to
f221ef0
Compare
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (main): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532} |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
814c521 to
f1e3968
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f1e3968 to
8bbbe45
Compare
Updated expiration notice for COCOAPODS_TRUNK_TOKEN.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 2d3e273. Configure here.
| name: Publish ${{ matrix.kit.name }} to CocoaPods | ||
| needs: [load-matrix, mirror-and-release-kits, release-core-sdk] | ||
| runs-on: macos-15 | ||
| if: ${{ !inputs.dry_run }} |
There was a problem hiding this comment.
Kit CocoaPods job skipped on manual non-dry-run dispatch
Medium Severity
The if: ${{ !inputs.dry_run }} condition on publish-kit-cocoapods uses the inputs context, where workflow_dispatch boolean inputs are strings ('true'/'false'), not actual booleans. Since 'false' is a non-empty string (truthy), !'false' evaluates to false, causing the entire job to be silently skipped when a user manually triggers the workflow with dry_run unchecked. Every other dry-run guard in this workflow uses the reliable env.DRY_RUN != 'true' pattern at step level, which correctly handles the string representation.
Reviewed by Cursor Bugbot for commit 2d3e273. Configure here.


Summary
The `release-publish` workflow had no step to push the core SDK or kits to CocoaPods trunk after GitHub releases. This adds two jobs to cover both.
Changes
Test plan