Conversation
PR SummaryMedium Risk Overview As a result, kit CocoaPods publishing is now correctly skipped when the workflow is executed as a dry run. Reviewed by Cursor Bugbot for commit f5d7810. Bugbot is set up for automated code reviews on this repo. Configure here. |
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (main): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532} |
Background
ifconditions in GitHub Actions do not have access to theenvcontext, only step-levelifconditions do. This meant thepublish-kit-cocoapodsjob's dry-run guard was silently ineffective — the job would always run, even during dry runs.What Has Changed
publish-kit-cocoapodsjob-leveliffromenv.DRY_RUN != 'true'togithub.event.inputs.dry_run != 'true'so the dry-run flag is correctly evaluated.Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)