Skip to content

ci: dry run flag alignment#725

Merged
nickolas-dimitrakas merged 1 commit intomainfrom
ci/dry-run-flag-alignment
Apr 8, 2026
Merged

ci: dry run flag alignment#725
nickolas-dimitrakas merged 1 commit intomainfrom
ci/dry-run-flag-alignment

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

Background

  • Job-level if conditions in GitHub Actions do not have access to the env context, only step-level if conditions do. This meant the publish-kit-cocoapods job's dry-run guard was silently ineffective — the job would always run, even during dry runs.

What Has Changed

  • Changed the publish-kit-cocoapods job-level if from env.DRY_RUN != 'true' to github.event.inputs.dry_run != 'true' so the dry-run flag is correctly evaluated.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • NO JIRA

@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Apr 8, 2026
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner April 8, 2026 17:19
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 8, 2026

PR Summary

Medium Risk
Changes the job-level gating for the CocoaPods publish job, which directly affects whether releases are published during a run. Low code complexity, but a mistake could cause unintended publishing or skipped publishes.

Overview
Fixes the release workflow’s dry-run behavior by updating the publish-kit-cocoapods job-level if condition to read from github.event.inputs.dry_run (instead of relying on a context not available at job scope).

As a result, kit CocoaPods publishing is now correctly skipped when the workflow is executed as a dry run.

Reviewed by Cursor Bugbot for commit f5d7810. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.75 MB 1.75 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.38 MB 6.38 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

@nickolas-dimitrakas nickolas-dimitrakas merged commit c6af40c into main Apr 8, 2026
69 of 71 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the ci/dry-run-flag-alignment branch April 8, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants