Skip to content

refactor: use local SDK path in kit Xcode projects#727

Merged
thomson-t merged 1 commit intomainfrom
refactor/kits-local-sdk-path
Apr 8, 2026
Merged

refactor: use local SDK path in kit Xcode projects#727
thomson-t merged 1 commit intomainfrom
refactor/kits-local-sdk-path

Conversation

@thomson-t
Copy link
Copy Markdown
Contributor

Summary

  • Convert kit SPM dependencies from remote GitHub references (XCRemoteSwiftPackageReference) to local path references (XCLocalSwiftPackageReference) pointing to the monorepo root
  • Kits now build against the local mParticle Apple SDK source instead of fetching from GitHub
  • Affected kits: FirebaseGA4 (11, 12), Firebase (11, 12), UrbanAirship (19, 20)

Test plan

  • Open each affected kit Xcode project and verify it resolves the local SDK package
  • Build each kit scheme for iOS and tvOS
  • Run kit unit tests

🤖 Generated with Claude Code

Convert kit SPM dependencies from remote GitHub references to local
path references so kits build against the monorepo's SDK source.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@thomson-t thomson-t requested a review from a team as a code owner April 8, 2026 18:41
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 8, 2026

PR Summary

Medium Risk
Build configuration only, but it changes how multiple kit Xcode projects resolve the core SDK dependency (remote GitHub branch -> local relative path), which can break builds for consumers/CI if the repo layout or package resolution differs.

Overview
Updates several kit Xcode projects (Firebase GA4 11/12, Firebase 11/12, UrbanAirship 19/20) to stop fetching mparticle-apple-sdk from GitHub and instead reference it via XCLocalSwiftPackageReference with relativePath = "../../..".

All mParticle-Apple-SDK product dependencies are rewired to this local package reference while leaving other remote dependencies (e.g. firebase-ios-sdk, ios-library) unchanged.

Reviewed by Cursor Bugbot for commit 49aa07e. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.75 MB 1.75 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.38 MB 6.38 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

@thomson-t thomson-t merged commit c3cf0d1 into main Apr 8, 2026
71 of 72 checks passed
@thomson-t thomson-t deleted the refactor/kits-local-sdk-path branch April 8, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants