Skip to content

chore: remove stale Carthage and semantic-release artifacts#730

Merged
nickolas-dimitrakas merged 1 commit intomainfrom
chore/remove-carthage-stale-docs
Apr 9, 2026
Merged

chore: remove stale Carthage and semantic-release artifacts#730
nickolas-dimitrakas merged 1 commit intomainfrom
chore/remove-carthage-stale-docs

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

Summary

  • Carthage is no longer a supported distribution method (no Cartfile, no CI job for Carthage consumers)
  • semantic-release is no longer used

Changes

Deleted:

  • Scripts/carthage.sh — Carthage build wrapper
  • Scripts/release.sh — called only by semantic-release
  • release.config.js — semantic-release config
  • mParticle_Apple_SDK.json — Carthage binary manifest (version-to-URL map)

Updated:

  • README.md — removed Carthage installation section and Carthage column from kits table
  • AGENTS.md — updated distribution methods to SPM + CocoaPods only, removed stale script references
  • SwiftExample/README.md — removed chmod +x ./Scripts/carthage.sh line
  • .github/workflows/sdk-release-maintenance-branch.yml — removed "Update Carthage JSON manifest" step, carthage.sh chmod, and mParticle_Apple_SDK.json from git add/commit message

Test plan

  • trunk check passes (verified locally — no issues)
  • Release workflow still builds and uploads xcframeworks to S3 correctly
  • No remaining Carthage references in docs/CI (CHANGELOG.md historical entries are intentionally kept)

🤖 Generated with Claude Code

Carthage is no longer a supported distribution method and semantic-release
is no longer used. Remove the Carthage binary manifest, build scripts,
semantic-release config, and all documentation references.

- Delete Scripts/carthage.sh, Scripts/release.sh, release.config.js,
  mParticle_Apple_SDK.json
- Remove Carthage installation section and kits table column from README.md
- Update AGENTS.md to reflect SPM + CocoaPods only distribution
- Remove carthage.sh chmod from SwiftExample/README.md
- Remove Carthage JSON manifest step from sdk-release-maintenance-branch.yml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner April 8, 2026 20:19
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 8, 2026

PR Summary

Medium Risk
Medium risk because it modifies the release automation workflow and deletes release-related scripts/manifests, which could break future release runs if any hidden dependencies remain. Product/runtime SDK code is untouched, so risk is largely limited to packaging and documentation.

Overview
Drops Carthage and semantic-release support artifacts by deleting Scripts/carthage.sh, Scripts/release.sh, release.config.js, and the Carthage binary manifest mParticle_Apple_SDK.json.

Updates release automation and docs to remove Carthage-specific steps and references: the maintenance-branch release workflow no longer updates/commits the JSON manifest or chmod the Carthage wrapper, and README.md, AGENTS.md, and SwiftExample/README.md now describe distribution via Swift Package Manager and CocoaPods only.

Reviewed by Cursor Bugbot for commit c534f02. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.75 MB 1.75 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.38 MB 6.38 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

@nickolas-dimitrakas nickolas-dimitrakas merged commit b4d1c30 into main Apr 9, 2026
68 of 72 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the chore/remove-carthage-stale-docs branch April 9, 2026 17:22
denischilik added a commit that referenced this pull request Apr 9, 2026
* main:
  chore: remove stale Carthage and semantic-release artifacts (#730)

# Conflicts:
#	Scripts/release.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants