Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the error if hv_vm_create fails #202

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Log the error if hv_vm_create fails #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/vmm/intel/vmx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,14 +466,31 @@ static int
vmx_init(void)
{
int error = hv_vm_create(HV_VM_DEFAULT);
if (error) {
if (error == HV_NO_DEVICE) {
switch (error) {
case HV_SUCCESS:
break;
case HV_ERROR:
/* Don't know if this can happen, report to us */
xhyve_abort("hv_vm_create HV_ERROR\n");
case HV_BUSY:
/* Should never happen, report to us (perhaps we need to retry) */
xhyve_abort("hv_vm_create HV_BUSY\n");
case HV_BAD_ARGUMENT:
/* Should never happen, report to Apple */
xhyve_abort("hv_vm_create HV_BAD_ARGUMENT\n");
case HV_NO_RESOURCES:
/* Don't know if this can happen, report to us */
xhyve_abort("hv_vm_create HV_NO_RESOURCES\n");
case HV_NO_DEVICE:
printf("vmx_init: processor not supported by "
"Hypervisor.framework\n");
return (error);
}
else
xhyve_abort("hv_vm_create failed\n");
case HV_UNSUPPORTED:
/* Don't know if this can happen, report to us */
xhyve_abort("hv_vm_create HV_UNSUPPORTED\n");
default:
/* Should never happen, report to Apple */
xhyve_abort("hv_vm_create unknown error %d\n", error);
}

/* Check support for primary processor-based VM-execution controls */
Expand Down