Fix filtering only participating notifications.

The actual query parameter was missing.
mackdk · Nov 18, 2024 · 3873690 · 3873690
1 parent e0cf74b
commit 3873690
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/typescript/client/GitHubClientImpl.ts b/src/main/typescript/client/GitHubClientImpl.ts
@@ -65,7 +65,7 @@ export class GitHubClientImpl implements GitHubClient {
     public async listThreads(showParticipatingOnly: boolean = false): Promise<GitHub.Thread[]> {
         const response = await this.doRequest(
             HttpMethod.GET,
-            `https://${this.baseUrl}/notifications?${showParticipatingOnly.toString()}`,
+            `https://${this.baseUrl}/notifications?participating=${showParticipatingOnly.toString()}`,
             [HttpStatus.Ok]
         );
 

diff --git a/src/test/resources/client/github-client-scenarios.json b/src/test/resources/client/github-client-scenarios.json
@@ -1,7 +1,7 @@
 {
     "fetch-all-threads": {
         "request": {
-            "url": "https://api.github.com/notifications?false",
+            "url": "https://api.github.com/notifications?participating=false",
             "method": "GET",
             "headers": {
                 "Authorization": "Bearer fake-token",
@@ -183,7 +183,7 @@
     },
     "fetch-threads-fails": {
         "request": {
-            "url": "https://api.github.com/notifications?false",
+            "url": "https://api.github.com/notifications?participating=false",
             "method": "GET",
             "headers": {
                 "Authorization": "Bearer fake-token",