fix(bench): Update benchmarks for new BonsaiStorage::new API#45
Draft
Mohiiit wants to merge 1 commit intoupdate-starknet-types-corefrom
Draft
fix(bench): Update benchmarks for new BonsaiStorage::new API#45Mohiiit wants to merge 1 commit intoupdate-starknet-types-corefrom
Mohiiit wants to merge 1 commit intoupdate-starknet-types-corefrom
Conversation
- Add max_height parameter to all BonsaiStorage::new calls - Remove .unwrap() as new() no longer returns Result - Add BitVec import - Add BENCH_KEY_HEIGHT constant (48 bits for 6-byte keys) The BonsaiStorage::new API was changed to require a max_height parameter, but the benchmarks were not updated, causing compilation failures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Mohiiit
force-pushed
the
fix/benchmark-api-update
branch
from
2920902 to
0a9ce22
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BonsaiStorage::newAPImax_heightparameter to allBonsaiStorage::newcalls.unwrap()asnew()no longer returnsResultBitVecimport andBENCH_KEY_HEIGHTconstantBackground
The
BonsaiStorage::newAPI was changed to require amax_heightparameter, but the benchmarks were not updated, causing compilation failures when runningcargo bench.Test plan
cargo bench --features "bench std rocksdb"compiles and runs successfullyGenerated with Claude Code