Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect License Requirements for Exchange Online Tests #670

Open
scs-ash opened this issue Feb 18, 2025 · 4 comments
Open

Incorrect License Requirements for Exchange Online Tests #670

scs-ash opened this issue Feb 18, 2025 · 4 comments
Assignees

Comments

@scs-ash
Copy link

scs-ash commented Feb 18, 2025

A lot of the Exchange Online tests are being skipped due to licensing requirements not being met. The warning message states it needs Defender for Office 365 Plan 2, but I believe all of these functions are available in Defender for Office 365 Plan 1. The tenant I'm running this on has Microsoft 365 Business Premium, so I would expect these tests not to be skipped.

Image

Image

@merill
Copy link
Contributor

merill commented Feb 19, 2025

Thanks for reporting.

Tagging @soulemike to review.

@soulemike
Copy link
Contributor

I would agree, these should all be achievable with EOP and not require MDO P1/P2.

We can add an Eop product switch to https://github.com/maester365/maester/blob/b17961cd51d7f1d89e537f65c78ea56d36b23087/powershell/public/Get-MtLicenseInformation.ps1

It looks like EOP uses 326e2b78-9d27-42c9-8509-46c827743a17, I don't see any explicit inclusion for Commercial/Gov/Edu SKUs though. We can start with that and if there is issues then add like we have with the others.

@scs-ash do you feel comfortable making that PR, or would you prefer I do?

Test-MtCisaAttachmentFileType MS.EXO.9.1v2
Test-MtCisaAttachmentFileType MS.EXO.9.2v1
Test-MtCisaAttachmentFileType MS.EXO.9.3v2
Test-MtCisaEmailFilterAlternative MS.EXO.9.4v1
Test-MtCisaBlockExecutable MS.EXO.9.5v1
Test-MtCisaAttachmentFilter MS.EXO.10.1v1
Test-MtCisaMalwareAction MS.EXO.10.2v1
Test-MtCisaMalwareZap MS.EXO.10.3v1
Test-MtCisaImpersonation MS.EXO.11.1v1
Test-MtCisaImpersonationTip MS.EXO.11.2v1
Test-MtCisaMailboxIntelligence MS.EXO.11.3v1

@scs-ash
Copy link
Author

scs-ash commented Feb 19, 2025

I would agree, these should all be achievable with EOP and not require MDO P1/P2.

We can add an Eop product switch to https://github.com/maester365/maester/blob/b17961cd51d7f1d89e537f65c78ea56d36b23087/powershell/public/Get-MtLicenseInformation.ps1

It looks like EOP uses 326e2b78-9d27-42c9-8509-46c827743a17, I don't see any explicit inclusion for Commercial/Gov/Edu SKUs though. We can start with that and if there is issues then add like we have with the others.

@scs-ash do you feel comfortable making that PR, or would you prefer I do?

Test-MtCisaAttachmentFileType MS.EXO.9.1v2 Test-MtCisaAttachmentFileType MS.EXO.9.2v1 Test-MtCisaAttachmentFileType MS.EXO.9.3v2 Test-MtCisaEmailFilterAlternative MS.EXO.9.4v1 Test-MtCisaBlockExecutable MS.EXO.9.5v1 Test-MtCisaAttachmentFilter MS.EXO.10.1v1 Test-MtCisaMalwareAction MS.EXO.10.2v1 Test-MtCisaMalwareZap MS.EXO.10.3v1 Test-MtCisaImpersonation MS.EXO.11.1v1 Test-MtCisaImpersonationTip MS.EXO.11.2v1 Test-MtCisaMailboxIntelligence MS.EXO.11.3v1

Hi Mike, thanks for the quick follow up. It's probably best if you create the PR on this one and I'll follow your lead for next time.

@tdcthosc
Copy link
Contributor

tdcthosc commented Mar 4, 2025

Hi

Should be resolved in #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants