Skip to content

Commit

Permalink
Merge pull request #9521 from magento-gl/AC-13818
Browse files Browse the repository at this point in the history
AC-13818::Make ES8 to be default for 2.4.8 instead of ES7
  • Loading branch information
glo71317 authored Feb 26, 2025
2 parents 4c8123c + efb6094 commit 71bfd9a
Show file tree
Hide file tree
Showing 55 changed files with 1,367 additions and 2,488 deletions.
2 changes: 1 addition & 1 deletion app/code/Magento/AdvancedSearch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The Magento_AdvancedSearch module introduces advanced search functionality and p
Before disabling or uninstalling this module, note that the following modules depends on this module:

- Magento_Elasticsearch
- Magento_Elasticsearch7
- Magento_Elasticsearch8

For information about module installation in Magento 2, see [Enable or disable modules](https://experienceleague.adobe.com/docs/commerce-operations/installation-guide/tutorials/manage-modules.html).

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ require([
'It is recommended to use OpenSearch as a search engine instead.'),
updateCommentText = () => {
const engineValue = engineField.val(),
newCommentText = ['elasticsearch7', 'elasticsearch8'].includes(engineValue) ?
newCommentText = ['elasticsearch8'].includes(engineValue) ?
unsupportedText : defaultText;

if (commentContainer.text() !== newCommentText) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
* Copyright 2022 Adobe
* All Rights Reserved.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="ChooseElasticSearchAsSearchEngineActionGroup">
<annotations>
<description>Goes to the 'Configuration' page for 'Catalog'. Sets the 'Search Engine' to 'elasticsearch7'. Clicks on the Save button. PLEASE NOTE: The value is Hardcoded.</description>
<description>Goes to the 'Configuration' page for 'Catalog'. Sets the 'Search Engine' to 'elasticsearch8'. Clicks on the Save button. PLEASE NOTE: The value is Hardcoded.</description>
</annotations>

<amOnPage url="{{AdminCatalogSearchConfigurationPage.url}}" stepKey="configureSearchEngine"/>
Expand All @@ -19,7 +19,7 @@
<conditionalClick selector="{{AdminCatalogSearchConfigurationSection.catalogSearchTab}}" dependentSelector="{{AdminCatalogSearchConfigurationSection.checkIfCatalogSearchTabExpand}}" visible="true" stepKey="expandCatalogSearchTab"/>
<waitForElementVisible selector="{{AdminCatalogSearchConfigurationSection.searchEngine}}" stepKey="waitForDropdownToBeVisible"/>
<uncheckOption selector="{{AdminCatalogSearchConfigurationSection.searchEngineDefaultSystemValue}}" stepKey="uncheckUseSystemValue"/>
<selectOption selector="{{AdminCatalogSearchConfigurationSection.searchEngine}}" userInput="Elasticsearch 7" stepKey="chooseES5"/>
<selectOption selector="{{AdminCatalogSearchConfigurationSection.searchEngine}}" userInput="Elasticsearch 8" stepKey="chooseES5"/>
<!--<scrollTo selector="{{AdminCatalogSearchConfigurationSection.catalogSearchTab}}" stepKey="scrollToCatalogSearchTab2"/>-->
<!--<click selector="{{AdminCatalogSearchConfigurationSection.catalogSearchTab}}" stepKey="collapseCatalogSearchTab"/>-->
<click selector="{{ContentManagementSection.Save}}" stepKey="saveConfiguration"/>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Elasticsearch/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"magento/module-store": "*",
"magento/module-catalog-inventory": "*",
"magento/framework": "*",
"magento/elasticsearch": "^1.0.0"
"elasticsearch/elasticsearch": "^8.15"
},
"suggest": {
"magento/module-config": "*"
Expand Down

This file was deleted.

28 changes: 0 additions & 28 deletions app/code/Magento/Elasticsearch7/README.md

This file was deleted.

Loading

0 comments on commit 71bfd9a

Please sign in to comment.