-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests/ fix failed tests #61
Integration tests/ fix failed tests #61
Conversation
…tStockTest::testProductStockStatusShouldBeUpdatedOnSchedule Zend_Db_Exception: Table "catalog_category_product_index_store0_replica" does not exist Partially reverting fix from Vinai: `Create category-product index table for store 0 (#47) This fixes a regression introduced by pull request https://github.com/mage-os/mageos-magento2/pull/25`
…de/Magento/CatalogInventory/Model/StockManagement.php:110 Test: dev/tests/integration/testsuite/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/DownloadableTest.php
Failed due to visibility filter in whishlist collection. Products were not added to root category and not reindexed. So visibility filter ued to exclude them from wishlist items collection: app/code/Magento/Wishlist/Model/ResourceModel/Item/Collection.php:390
Include and use changed workflow to have more unitary tests executions
…zend-db#1 Error that was fixed: Unable to revert fixture: Magento/Framework/Backup/_files/trigger.php #0 /var/www/html/dev/tests/integration/testsuite/Magento/Framework/Backup/DbTest.php(42): Magento\Framework\Backup\DbTest->testBackupAndRollbackIncludesCustomTriggers() ...
Magento\Framework\Image\Adapter\InterfaceTest::testRotate with data set #4 ('/var/www/html/dev/tests/integ...st.png', 45, array(157, 35), 'IMAGEMAGICK') ImagickException: unrecognized color `srgb255,255,255' @ warning/color.c/GetColorCompliance/1064
Magento\Framework\Image\Adapter\InterfaceTest::testCreatePngFromString with data set #1 (array(5, 12), array(0, 0, 0), array(0, 20), array(255, 255, 255), 'IMAGEMAGICK') ImagickException: unable to read font `' @ error/annotate.c/RenderFreetype/1636
Magento\Dhl\Model\CarrierTest::testRequestToShip with data set #0 ('GB', 'EU', 'US') Failed asserting that two DOM documents are equal. - <SoftwareName>Magento</SoftwareName> + <SoftwareName>Mage-OS</SoftwareName>
Magento\Framework\Image\Adapter\InterfaceTest::testCreatePngFromString with data set #1 (array(5, 12), array(0, 0, 0), array(0, 20), array(255, 255, 255), 'IMAGEMAGICK') PHPUnit\Framework\Exception: Deprecated: Implicit conversion from float 11.34375 to int loses precision in /var/www/html/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php:505.
Magento\Framework\Image\Adapter\InterfaceTest::testCreatePngFromString with data set #1 (array(5, 12), array(0, 0, 0), array(0, 20), array(255, 255, 255), 'IMAGEMAGICK') PHPUnit\Framework\Exception: Deprecated: Implicit conversion from float 11.34375 to int loses precision in /var/www/html/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php:505.
Magento\Framework\Image\Adapter\InterfaceTest::testRotate with data set #4 ('/var/www/html/dev/tests/integ...st.png', 45, array(157, 35), 'IMAGEMAGICK') ImagickException: unrecognized color `srgb255,255,255' @ warning/color.c/GetColorCompliance/1064
This reverts commit f01535b.
This reverts commit 7be2613.
Integration tests/graphql fix
…nput-over-test-directory Add optional param to run tests over specific directory only.
Update package name to mage-os
… resolving): error msg: 1) Magento\Catalog\Block\Adminhtml\Category\Checkboxes\TreeTest::testGetTreeJson Error: Call to a member function getConnectionName() on null /var/www/html/lib/internal/Magento/Framework/App/ResourceConnection.php:110 /var/www/html/app/code/Magento/Catalog/Model/ResourceModel/Category/Collection.php:570 ... ref: https://github.com/vpodorozh/mageos-magento2/actions/runs/7472531139/job/20334972566#step:6:39
Fix failed integration tests in \Magento\Customer
Fix failed tests: \Magento\Version\Controller\Index\IndexTest
just checked It looks like it was added in eceb5d9, and it depends on some overrides.xml file, that isn't triggered when running tests from specific folder. Do anyone know what is the overrides.xml file designed for and how to integrate it properly? Might be related extdn/github-actions-m2#56, @damienwebdev maybe you know something about it? |
Hi @vpodorozh, |
Revert "Fix failed integration tests in \Magento\Customer"
Actually only one thing was fixed in latest 2.4-develop - related to spaces in page generation. And Magento have added a one more new bug - https://github.com/vpodorozh/mageos-magento2/actions/runs/7596143665/job/20689518571#step:6:34 For detailed test results on various Magento versions (Mage-OS, Magento + latest updated) - lookup here: https://docs.google.com/spreadsheets/d/1bGJZ1PBY6HS4hyhJyWVX0SnEOcbESnew40Myo2Bkmn4/edit?usp=sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change those two small things I commented on?
UPDATE: both comments resolved
Great @Vinai . I;ve also double-checked the fix from zend-db - works fine. |
Description (*)
Pull Request must contain fixes and changes to failed/error integration tests and/or functionality they cover.
Related Pull Requests
Current state:
tests total: 13311
failing: 37 ( https://github.com/vpodorozh/mageos-magento2/actions/runs/7476706132 )
tests in unclear status: ~0
Integration Tests Execution results on various Magento versions:
https://docs.google.com/spreadsheets/d/1bGJZ1PBY6HS4hyhJyWVX0SnEOcbESnew40Myo2Bkmn4/edit?usp=sharing
Issues to be Solved/Fixed:
Checkout
:ref - fixed by @novikorGraphQl
:ref - WIP by @novikorCustomer
:ref - fixed by @ihor-sviziev ( https://github.com/vpodorozh/mageos-magento2/pull/8 )ConfigurableProduct
:ref - fixed by @novikor and @vpodorozhTestModuleOverrideConfig
:refWishlist
:ref - fixed by @novikorCatalog
Framework
:refFixes ref:
* f3136c9
* 8d29065
* ba1b153
* c9da6b7
Bundle
Version
:ref - fixed by @ihor-svizievSales
:ref - fixed by @novikor and @vpodorozhCatalogWidget
:ref - fixed by @novikorCatalogInventory
Security
:ref - WIP by @vpodorozhContribution
vpodorozh:integration-tests/fix-tests
(this PR branch)vladyslavpodorozhnyi