New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix when omitting variable in catch clause #73

Open

bramstroker wants to merge 1 commit into magento-ecg:master from bramstroker:patch-1

bramstroker commented Oct 9, 2024

Using the following construct:

try {
} catch (\My\Namespace\MyException) {
}

Results in:

1 | ERROR | Namespace for "<?php" class is not specified.

This PR fixes this so both scenarios with a variable or without variable in the catch clause will work.


          fix when omitting variable in catch clause

e717d55

pmzandbergen commented Oct 9, 2024

Note: This is supported on PHP >= 8.0.0

See https://www.php.net/manual/en/language.exceptions.php

As of PHP 8.0.0, the variable name for a caught exception is optional. If not specified, the catch block will still execute but will not have access to the thrown object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet