This repository was archived by the owner on Apr 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Eliminate usage of Zend_Mail from Magento 2 Open Source #136
Open
mhauri
wants to merge
3
commits into
magento-engcom:2.3.1-develop
Choose a base branch
from
mhauri:remove-zend-mail
base: 2.3.1-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,9 @@ class TemplateTest extends \PHPUnit\Framework\TestCase | |
protected $model; | ||
|
||
/** | ||
* @var \Zend_Mail|\PHPUnit_Framework_MockObject_MockObject | ||
* @var \Magento\Framework\Mail\Message|\PHPUnit_Framework_MockObject_MockObject | ||
*/ | ||
protected $mail; | ||
protected $message; | ||
|
||
/** | ||
* @var \Magento\Framework\ObjectManagerInterface | ||
|
@@ -45,8 +45,8 @@ protected function mockModel($filesystem = null) | |
$filesystem = $this->objectManager->create(\Magento\Framework\Filesystem::class); | ||
} | ||
|
||
$this->mail = $this->getMockBuilder(\Zend_Mail::class) | ||
->setMethods(['send', 'addTo', 'addBcc', 'setReturnPath', 'setReplyTo']) | ||
$this->message = $this->getMockBuilder(\Magento\Framework\Mail\Message::class) | ||
->setMethods(['addTo', 'addBcc', 'setReplyTo']) | ||
->setConstructorArgs(['utf-8']) | ||
->getMock(); | ||
|
||
|
@@ -71,18 +71,18 @@ protected function mockModel($filesystem = null) | |
|
||
$this->objectManager->get(\Magento\Framework\App\State::class)->setAreaCode('frontend'); | ||
|
||
$this->model->expects($this->any())->method('_getMail')->will($this->returnCallback([$this, 'getMail'])); | ||
$this->model->expects($this->any())->method('_getMail')->will($this->returnCallback([$this, 'getMessage'])); | ||
$this->model->setSenderName('sender')->setSenderEmail('[email protected]')->setTemplateSubject('Subject'); | ||
} | ||
|
||
/** | ||
* Return a disposable \Zend_Mail instance | ||
* Return a disposable \Magento\Framework\Mail\Message instance | ||
* | ||
* @return \PHPUnit_Framework_MockObject_MockObject|\Zend_Mail | ||
*/ | ||
public function getMail() | ||
public function getMessage() | ||
{ | ||
return clone $this->mail; | ||
return clone $this->message; | ||
} | ||
|
||
public function testSetGetTemplateFilter() | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
_getMail()
method doesn't exist anymore. It shouldn't be necessary here then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @buskamuza for catching this, I overlooked it. Will fix it asap.
This test seems to be obsolete, am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... probably the test itself still makes some sense. But anything related to
$this->mail
does not.