Skip to content

Cleanup: don't use void return value from method calls. #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2025
Merged

Cleanup: don't use void return value from method calls. #881

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa33cda
Don't use void return value from parent. Fixes error phpstan found wh…
hostep Dec 31, 2024
5fdb88b
Fixed static tests.
hostep Dec 31, 2024
b950b13
Merge branch 'develop' into fixed-returning-from-method-that-doesnt-r…
engcom-Hotel Jan 20, 2025
fb1286e
Merge branch 'develop' into fixed-returning-from-method-that-doesnt-r…
engcom-Bravo Jan 29, 2025
24e5126
Merge remote-tracking branch 'upstream/develop' into fixed-returning-…
hostep Feb 26, 2025
c6d6bef
Merge remote-tracking branch 'upstream/develop' into fixed-returning-…
hostep Mar 24, 2025
90db981
Merge branch 'develop' into fixed-returning-from-method-that-doesnt-r…
engcom-Hotel Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/code/Magento/PageBuilder/Controller/Adminhtml/Stage/Render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<?php
/**
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2019 Adobe
* All Rights Reserved.
*/

namespace Magento\PageBuilder\Controller\Adminhtml\Stage;
Expand All @@ -18,7 +17,7 @@
*/
class Render extends \Magento\Backend\App\Action implements HttpGetActionInterface
{
const ADMIN_RESOURCE = 'Magento_Backend::content';
public const ADMIN_RESOURCE = 'Magento_Backend::content';

/**
* @var \Magento\Framework\View\Result\PageFactory
Expand All @@ -36,7 +35,8 @@ public function __construct(
PageFactory $pageFactory
) {
$this->pageFactory = $pageFactory;
return parent::__construct($context);

parent::__construct($context);
}

/**
Expand Down