-
Notifications
You must be signed in to change notification settings - Fork 74
Fixed Banner element overlay issue on mobile when min-height is customized #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@magento create issue |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ChavdaNayan,
Thanks for the contribution!
The changes looks good to us, but please fix the failed static test failures. Other failures seems flaky to me.
Thanks
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests |
@magento run all tests |
Hello @engcom-Hotel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ChavdaNayan,
Thanks for making the changes!
The failed tests seems flaky to me, but please fix the copyright year below.
Thanks
@@ -2,8 +2,8 @@ | |||
/* jscs:disable */ | |||
define(["Magento_PageBuilder/js/utils/object"], function (_object) { | |||
/** | |||
* Copyright © Magento, Inc. All rights reserved. | |||
* See COPYING.txt for license details. | |||
* Copyright 2025 Adobe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright year should be the year when the file was created:
* Copyright 2025 Adobe | |
* Copyright 2018 Adobe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @engcom-Hotel
Changed the copyright year to reflect the file's creation year.
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests |
@magento run all tests |
Preconditions (*)
Tested in this versions:
Magento 2.4.8
Description (*)
When we set a custom minimum height for the banner, the content overlay doesn’t show up on the mobile frontend.
Steps to reproduce (*)
Screenshot-1
Expected result (*)
When setting a custom minimum height value for the Banner element in Page Builder’s mobile view, the content overlay (text/button layer) should be visible (See Screenshot 2).
Screenshot-2
Actual result (*)
When setting a custom minimum height value for the Banner element in Page Builder’s mobile view, the content overlay (text/button layer) is not clearly visible (See Screenshot 3).
Screenshot-3
Additional information (*)
In the banner element on mobile viewports, when we change the custom minimum height value, the banner overlay background color becomes transparent (See Screenshot 4).
Screenshot-4
Resolved issues: