Skip to content

PageBuilder save very slow in Chrome #37798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
quanghien95 opened this issue Jul 25, 2023 · 28 comments
Closed
1 of 5 tasks

PageBuilder save very slow in Chrome #37798

quanghien95 opened this issue Jul 25, 2023 · 28 comments
Assignees
Labels
Area: Content Component: PageBuilder Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@quanghien95
Copy link

quanghien95 commented Jul 25, 2023

Preconditions and environment

  • Magento version: 2.4.5-p2 and 2.4.6
  • PageBuilder is enabled
  • Chrome 112 and newer
  • CMS page with pagebuilder content

Steps to reproduce

  1. Use Chrome version 112 or above
  2. Edit CMS Page, Product or anything that has PageBuilder.
  3. Save page. It takes very long time or save or loading forever.
    JS file is loading from the networks instead of browser cache, so that saving is very slow

Expected result

The content saving quickly.
JS file should getting from browser cache

Actual result

JS files always loading from the networks.
The content saving very slow. Sometime its stuck forever.

Additional information

I see that the issue happen when page builder rendering in iframe. Some js file is always loading from networks instead of browser cached. So that we have to spent more time to wait until all js file is loading correct.
Sometime, when network is slow. The spin loading forever and the content is not save and we will lost the current work.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2023

Hi @quanghien95. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@quanghien95
Copy link
Author

@magento give me 2.4-develop instance
@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2023

Hi @quanghien95! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@magento-deployment-service
Copy link

Hi @quanghien95. Thank you for your request. I'm working on Magento instance for you.

@quanghien95
Copy link
Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2023

Hi @quanghien95! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.6 Indicates original Magento version for the Issue report. label Jul 25, 2023
@quanghien95
Copy link
Author

@magento I am working on this

@magento-deployment-service
Copy link

@hostep
Copy link
Contributor

hostep commented Jul 25, 2023

Sounds like a duplicate of #37516 ?

This might fix your issue: #37516 (comment)

Let us know if that did the trick? And then close this ticket. Thanks! 🙂

@quanghien95
Copy link
Author

@hostep
Thanks for your information.
I read this issue #37516. But its not fix my issue.
These js file always loading from networks instead of browser cache when page builder open.
In case slow network. It can take very long time to save the cms content.
Let me update the issue description for more clear.

I can reproduce this issue in current 2.4-develop instance
Please kindly check this video screenshot:

Screen.Recording.2023-07-25.at.17.11.18.mov

@quanghien95
Copy link
Author

This Is the PR to fixing this issue:
magento/magento2-page-builder#854

@norgeindian
Copy link

@quanghien95 , I included the fix, but unfortunately it did not change anything for me. The page still needs 30 secs to save. But I actually have the problem on product pages. Does that make a difference?

@quanghien95
Copy link
Author

@norgeindian
This should be the same. You also need to apply this patch and patch #37516 together.
Check the network and make sure that some js file is loading correct from browser cache instead of from networks

@norgeindian
Copy link

@quanghien95 , thanks for the clarification. With both patches together, it actually works. Thanks a lot for the fix.

@thanhndmagento
Copy link

Thank you! It works for me. The PageBuilder was very slow before

@engcom-Delta engcom-Delta self-assigned this Sep 14, 2023
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2023

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Delta
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Sep 15, 2023

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Issue occurs when page builder rendering in iframe. Some js file is always loading from networks instead of browser cached.

1	Using Chrome version 112 or above
2	Edit CMS Page, Product or anything that has PageBuilder.
3	Save page. It takes very long time or save or loading forever.
JS file is loading from the networks instead of browser cache, so that saving is very slow

Attaching recording

Untitled.mp4

and screenshot

Screenshot 2023-09-15 at 3 00 56 PM

Hence Confirming the issue.

@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Sep 15, 2023
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 15, 2023
@m2-community-project m2-community-project bot added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation labels Sep 15, 2023
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 15, 2023
@engcom-Delta engcom-Delta added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Sep 15, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9567 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2023

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Bravo
Copy link
Contributor

Hi @quanghien95,

As per this comment #39076 (comment) issue has been fixed hence we are closing this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: PageBuilder Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

7 participants