Skip to content

Fix issue: JS not loading from browser cache when page builder render #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

quanghien95
Copy link
Contributor

Issue: magento/magento2#37798

Preconditions and environment
Magento version: 2.4.5-p2 and 2.4.6
PageBuilder is enabled
Chrome 112 and newer
CMS page with pagebuilder content
Steps to reproduce
Use Chrome version 112 or above
Edit CMS Page, Product or anything that has PageBuilder.
Save page. It takes very long time or save or loading forever.
JS file is loading from the networks instead of browser cache, so that saving is very slow
Expected result
The content saving quickly.
JS file should getting from browser cache

Actual result
JS files always loading from the networks.
The content saving very slow. Sometime its stuck forever.

Additional information
I see that the issue happen when page builder rendering in iframe. Some js file is always loading from networks instead of browser cached. So that we have to spent more time to wait until all js file is loading correct.
Sometime, when network is slow. The spin loading forever and the content is not save and we will lost the current work.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker, WebAPI Tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @quanghien95,

Thanks for the contribution!

Please check the build failures. It seems they are due to code changes.

Thanks

@engcom-Hotel
Copy link
Collaborator

Hello @quanghien95, We are picking up this PR for further fixes.

@engcom-Hotel
Copy link
Collaborator

Hello @quanghien95,

Thanks for the contribution!

As we have no access to this PR branch, we have created a new PR to accommodate this PR commit. Please check the further process of the fix in the below PR:

https://github.com/magento-commerce/magento2-page-builder/pull/290

Closing this PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants