Skip to content

fixed issue #18724 for 2.3-develop #19177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

fixed issue #18724 for 2.3-develop #19177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21c9183
fixed issue #18724 for 2.3-develop
Nov 12, 2018
6d60eb2
update notation
Nov 21, 2018
3e306c4
Merge branch '2.3-develop' of https://github.com/Shubham-Webkul/magen…
Nov 21, 2018
b00cfbd
Merge branch '2.3-develop' of https://github.com/Shubham-Webkul/magen…
Dec 13, 2018
4619843
Merge branch '2.3-develop' of https://github.com/Shubham-Webkul/magen…
Dec 19, 2018
d42410a
fixed $ sign in percent
Dec 19, 2018
f1cacc4
fixed travis CI issue
Dec 20, 2018
339ce18
fixed conflict
Feb 28, 2019
9a393e9
Update tax.js
Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Tax/view/frontend/templates/order/tax.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<td <?= /* @escapeNotVerified */ $block->getLabelProperties() ?>>
<?= $block->escapeHtml($title) ?>
<?php if (!is_null($percent)): ?>
(<?= (float)$percent ?>%)
(<?= /* @escapeNotVerified */ $_order->formatPrice((float)$percent) ?>%)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not verified here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur because it was reject in Travis CI process due to XSS vulnerability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shubham-Webkul there should be another annotation, like noEscape, to indicate escaping is not needed and logic was verified.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur I have updated in this commit 6d60eb2

<?php endif; ?>
<br />
</td>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Tax/view/frontend/web/template/checkout/summary/tax.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<!-- ko foreach: rates -->
<tr class="totals-tax-details">
<!-- ko if: percent -->
<th class="mark" scope="row" data-bind="text: title + ' (' + percent + '%)'"></th>
<th class="mark" scope="row" data-bind="text: title + ' (' + $parents[1].formatPrice(percent) + '%)'"></th>
<!-- /ko -->
<!-- ko if: !percent -->
<th class="mark" scope="row" data-bind="text: title"></th>
Expand Down